sergiotarxz/nuttx
sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drivers/lcd/st7789: fix invalid displayed color

Browse Source 
The write has to be in number of bytes per pixel as single SPI exchange
is used to identify single pixel write by the ST7789 driver. By issuing
only byte writes the displayed color is corrupted as it is stripped.

This fix consist of setting SPI to correct number of exchanged bytes and
then passing correctly number of words to the SPI exchange.

This also covers usage of st7789_wrram in st7789_putrun as that one was
passing just number of pixels as size but the correct is now number of
bytes.
This commit is contained in:
Karel Kočí 2022-11-21 15:44:40 +01:00 committed by Alan Carvalho de Assis
parent 039262484a
commit 221b098846
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/lcd/st7789.c
View File

@ -455,11 +455,12 @@ static void st7789_wrram(FAR struct st7789_dev_s *dev,
st7789_sendcmd(dev, ST7789_RAMWR);
st7789_select(dev->spi, 8);
st7789_select(dev->spi, ST7789_BYTESPP * 8);
for (i = 0; i < count; i++)
{
SPI_SNDBLOCK(dev->spi, buff + (i * (size + skip)), size);
SPI_SNDBLOCK(dev->spi, buff + (i * (size + skip)),
size / ST7789_BYTESPP);
}
st7789_deselect(dev->spi);
@ -535,7 +536,7 @@ static int st7789_putrun(FAR struct lcd_dev_s *dev,
DEBUGASSERT(buffer && ((uintptr_t)buffer & 1) == 0);
st7789_setarea(priv, col, row, col + npixels - 1, row);
st7789_wrram(priv, buffer, npixels, 0, 1);
st7789_wrram(priv, buffer, npixels * ST7789_BYTESPP, 0, 1);
return OK;
}
@ -568,7 +569,7 @@ static int st7789_putarea(FAR struct lcd_dev_s *dev,
FAR struct st7789_dev_s *priv = (FAR struct st7789_dev_s *)dev;
size_t cols = col_end - col_start + 1;
size_t rows = row_end - row_start + 1;
size_t row_size = cols * (priv->bpp >> 3);
size_t row_size = cols * ST7789_BYTESPP;
ginfo("row_start: %d row_end: %d col_start: %d col_end: %d\n",
row_start, row_end, col_start, col_end);