sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drivers/video/fb.c: File offset is in units of bytes, not pixels.

Browse Source
This commit is contained in:
Gregory Nutt 2017-09-14 08:43:41 -06:00
parent 13006ecca9
commit 278532eb44
1 changed files with 2 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/video/fb.c
View File

@ -76,8 +76,6 @@ struct fb_chardev_s
* Private Function Prototypes
****************************************************************************/
static size_t fb_pixel2byte(FAR struct fb_chardev_s *fb, size_t pixsize);
static int fb_open(FAR struct file *filep);
static int fb_close(FAR struct file *filep);
static ssize_t fb_read(FAR struct file *filep, FAR char *buffer,
@ -111,19 +109,6 @@ static const struct file_operations fb_fops =
* Private Functions
****************************************************************************/
/****************************************************************************
* Name: fb_pixel2byte
*
* Description:
* Convert a value in units of pixels to units of bytes.
*
****************************************************************************/
static size_t fb_pixel2byte(FAR struct fb_chardev_s *fb, size_t pixsize)
{
return (pixsize * fb->bpp) >> 3; /* Overflow possible? */
}
/****************************************************************************
* Name: fb_open
*
@ -174,7 +159,7 @@ static ssize_t fb_read(FAR struct file *filep, FAR char *buffer, size_t len)
/* Get the start and size of the transfer */
start = fb_pixel2byte(fb, filep->f_pos);
start = filep->f_pos;
if (start >= fb->fblen)
{
return 0; /* Return end-of-file */
@ -217,7 +202,7 @@ static ssize_t fb_write(FAR struct file *filep, FAR const char *buffer, size_t l
/* Get the start and size of the transfer */
start = fb_pixel2byte(fb, filep->f_pos);
start = filep->f_pos;
if (start >= fb->fblen)
{
return -EFBIG; /* Cannot extend the framebuffer */