sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merged in fbraghiroli/nuttx/fix_nrf24l01 (pull request #922)

Browse Source 
nrf24l01: fix PIPENO/PKTLEN bitmask in rx fifo header

In RX fifo header, the first byte should use 5 lsb to store PKTLEN
and 3 msb to store PIPENO. However, FIFO_PIPENO_SHIFT was set to 4
which causes the lsb of pipe number to interfere with the received
packet size stored in the fifo.

This fix rx corruption when using pipe number > 0.

Signed-off-by: Federico Braghiroli <federico.braghiroli@gmail.com>

Approved-by: Gregory Nutt <gnutt@nuttx.org>
This commit is contained in:
Federico Braghiroli 2019-06-29 16:56:57 +00:00 committed by Gregory Nutt
parent 3f9ef89e19
commit 2dd1b330e5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/wireless/nrf24l01.c
View File

@ -116,7 +116,7 @@
#define FIFO_PKTLEN_MASK 0x1F /* 5 ls bits used to store packet length */
#define FIFO_PKTLEN_SHIFT 0
#define FIFO_PIPENO_MASK 0xE0 /* 3 ms bits used to store pipe # */
#define FIFO_PIPENO_SHIFT 4
#define FIFO_PIPENO_SHIFT 5
#define FIFO_PKTLEN(dev) \
(((dev->rx_fifo[dev->nxt_read] & FIFO_PKTLEN_MASK) >> FIFO_PKTLEN_SHIFT) + 1)