sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Correct an NX error that would leave stuff on the display when a window is closed

Browse Source 
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@3769 42af7a65-404d-4744-a932-0658087f49c3
This commit is contained in:
patacongo 2011-07-11 13:30:47 +00:00
parent 395778f0f2
commit 2ff6c3793c
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog
View File

@ -1892,3 +1892,6 @@
* graphics/nxbe/nxbe_move.c: Fixed an error in the graphics move logic (This * graphics/nxbe/nxbe_move.c: Fixed an error in the graphics move logic (This
was a previously untested interface). Basically, there is some confusion was a previously untested interface). Basically, there is some confusion
between use of (x,y) as a relative offset or as an absolute position. between use of (x,y) as a relative offset or as an absolute position.
* graphics/nxbe/nxbe_close.c: Fixed an important graphics system bug:
When a window is closed, the display was not being updated. The old
window graphic was left on the display for a time.

6
TODO
View File

@ -14,7 +14,7 @@ nuttx/
(2) USB (drivers/usbdev, drivers/usbhost) (2) USB (drivers/usbdev, drivers/usbhost)
(6) Libraries (lib/) (6) Libraries (lib/)
(13) File system/Generic drivers (fs/, drivers/) (13) File system/Generic drivers (fs/, drivers/)
(2) Graphics subystem (graphics/) (1) Graphics subystem (graphics/)
(1) Pascal add-on (pcode/) (1) Pascal add-on (pcode/)
(1) Documentation (Documentation/) (1) Documentation (Documentation/)
(4) Build system / Toolchains (4) Build system / Toolchains
@ -484,10 +484,6 @@ o Graphics subystem (graphics/)
Status: Open Status: Open
Priority: Medium Priority: Medium
Description: When a window is closed, the display is not updated.
Status: Open
Priority: High
o Pascal Add-On (pcode/) o Pascal Add-On (pcode/)
^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^

9
graphics/nxbe/nxbe_closewindow.c
View File

@ -104,7 +104,7 @@ void nxbe_closewindow(struct nxbe_window_s *wnd)
if (wnd->above) if (wnd->above)
{ {
/* Yes, now the window below that on is the window below /* Yes, now the window below that one is the window below
* the one being closed. * the one being closed.
*/ */
@ -126,5 +126,12 @@ void nxbe_closewindow(struct nxbe_window_s *wnd)
*/ */
wnd->below->above = wnd->above; wnd->below->above = wnd->above;
/* Redraw the windows that were below us (and may now be exposed) */
nxbe_redrawbelow(be, wnd->below, &wnd->bounds);
/* Then discard the window structure */
free(wnd); free(wnd);
} }