Consolidate buffer dumping; fix all occurrences of 'the the'

git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@1951 42af7a65-404d-4744-a932-0658087f49c3

arch/arm/include/cortexm3/irq.h

@@ -160,7 +160,7 @@ static inline irqstate_t irqsave(void)
 {
   unsigned short primask;
 
-  /* Return the the current value of primask register and set
+  /* Return the current value of primask register and set
    * bit 0 of the primask register to disable interrupts
    */
 

arch/arm/src/arm/up_sigdeliver.c

@@ -86,7 +86,7 @@ void up_sigdeliver(void)
   sig_deliver_t sigdeliver;
 
   /* Save the errno.  This must be preserved throughout the
-   * signal handling so that the the user code final gets
+   * signal handling so that the user code final gets
    * the correct errno value (probably EINTR).
    */
 

arch/arm/src/c5471/c5471_ethernet.c

@@ -415,53 +415,16 @@ static void c5471_macassign(struct c5471_driver_s *c5471);
  ****************************************************************************/
 
 #ifdef CONFIG_C5471_NET_DUMPBUFFER
-static void c5471_dumpbuffer(const char *buffer, ssize_t nbytes)
+static inline void c5471_dumpbuffer(const char *msg, const ubyte *buffer, unsigned int nbytes)
 {
-#if defined(CONFIG_DEBUG) && defined(CONFIG_DEBUG_NET)
-  char line[128];
-  int ch;
-  int i;
-  int j;
+  /* CONFIG_DEBUG, CONFIG_DEBUG_VERBOSE, and CONFIG_DEBUG_NET have to be
+   * defined or the following does nothing.
+   */
     
-  for (i = 0; i < nbytes; i += 16)
-    {
-      sprintf(line, "%04x: ", i);
-      for (j = 0; j < 16; j++)
-        {
-          if (i + j < nbytes)
-            {
-              sprintf(&line[strlen(line)], "%02x", buffer[i+j] );
-            }
-          else
-            {
-              strcpy(&line[strlen(line)], "  ");
-            }
-
-          if (j == 7 || j == 15)
-            {
-              strcpy(&line[strlen(line)], " ");
-           }
-        }
-
-      for ( j = 0; j < 16; j++)
-        {
-          if (i + j < nbytes)
-            {
-              ch = buffer[i+j];
-              sprintf(&line[strlen(line)], "%c", ch >= 0x20 && ch <= 0x7e ? ch : '.');
-            }
-
-          if (j == 7 || j == 15)
-            {
-              strcpy(&line[strlen(line)], " ");
-           }
-        }
-      ndbg("%s\n", line);
-    }
-#endif
+  nvdbgdumpbuffer(msg, buffer, nbytes);
 }
 #else
-# define c5471_dumpbuffer(buffer,nbytes)
+# define c5471_dumpbuffer(msg, buffer,nbytes)
 #endif
 
 /****************************************************************************
@@ -494,7 +457,7 @@ static void c5471_mdtxbit (int bit_state)
 
   putreg32((getreg32(GPIO_CIO) & ~GPIO_CIO_MDIO), GPIO_CIO);
 
-  /* Select the the bit output state */
+  /* Select the bit output state */
 
   if (bit_state)
     {
@@ -907,7 +870,7 @@ static int c5471_transmit(struct c5471_driver_s *c5471)
   c5471->c_lastdescstart = c5471->c_rxcpudesc;
 
   nvdbg("Packet size: %d RX CPU desc: %08x\n", nbytes, c5471->c_rxcpudesc);
-  c5471_dumpbuffer(dev->d_buf, dev->d_len);
+  c5471_dumpbuffer("Transmit packet", dev->d_buf, dev->d_len);
 
   while (nbytes)
     {
@@ -1276,7 +1239,7 @@ static void c5471_receive(struct c5471_driver_s *c5471)
 
       dev->d_len = packetlen;
       nvdbg("Received packet, packetlen: %d type: %02x\n", packetlen, ntohs(BUF->type));
-      c5471_dumpbuffer(dev->d_buf, dev->d_len);
+      c5471_dumpbuffer("Received packet", dev->d_buf, dev->d_len);
 
       /* We only accept IP packets of the configured type and ARP packets */
 
@@ -2006,7 +1969,7 @@ static void c5471_eimconfig(struct c5471_driver_s *c5471)
   putreg32(ENET_ADR_BROADCAST|ENET_ADR_PROMISCUOUS, ENET0_ADRMODE_EN);
 #else 
   /* The CPU port is not PROMISCUOUS, it wants a no-promiscuous address
-   * match yet the the SWITCH receives packets from the PROMISCUOUS ENET0
+   * match yet the SWITCH receives packets from the PROMISCUOUS ENET0
    * which routes all packets for filter matching at the CPU port which
    * then allows the s/w to see the new incoming packetes that passed
    * the filter. Here we are setting the main SWITCH closest the ether

arch/arm/src/c5471/c5471_watchdog.c

@@ -287,7 +287,7 @@ static int wdt_ioctl(struct file *filep, int cmd, uint32 arg)
 {
   dbg("ioctl Call: cmd=0x%x arg=0x%x", cmd, arg);
 
-  /* Process the the IOCTL command (see arch/watchdog.h) */
+  /* Process the IOCTL command (see arch/watchdog.h) */
 
   switch(cmd)
     {

arch/arm/src/common/up_blocktask.c

@@ -74,7 +74,7 @@
  *
  * Inputs:
  *   tcb: Refers to a task in the ready-to-run list (normally
- *     the task at the the head of the list).  It most be
+ *     the task at the head of the list).  It most be
  *     stopped, its context saved and moved into one of the
  *     waiting task lists.  It it was the task at the head
  *     of the ready-to-run list, then a context to the new

arch/arm/src/common/up_exit.c

@@ -136,7 +136,7 @@ static void _up_dumponexit(FAR _TCB *tcb, FAR void *arg)
  *   This function causes the currently executing task to cease
  *   to exist.  This is a special case of task_delete() where the task to
  *   be deleted is the currently executing task.  It is more complex because
- *   a context switch must be perform to the the next ready to run task.
+ *   a context switch must be perform to the next ready to run task.
  *
  ****************************************************************************/
 

arch/arm/src/common/up_internal.h

@@ -74,7 +74,7 @@
 /* Macros to handle saving and restore interrupt state.  In the current ARM
  * model, the state is always copied to and from the stack and TCB.  In the
  * Cortex-M3 model, the state is copied from the stack to the TCB, but only
- * a referenced is passed to get the the state from the TCB.
+ * a referenced is passed to get the state from the TCB.
  */
 
 #ifdef CONFIG_ARCH_CORTEXM3

arch/arm/src/cortexm3/up_sigdeliver.c

@@ -86,7 +86,7 @@ void up_sigdeliver(void)
   sig_deliver_t sigdeliver;
 
   /* Save the errno.  This must be preserved throughout the
-   * signal handling so that the the user code final gets
+   * signal handling so that the user code final gets
    * the correct errno value (probably EINTR).
    */
 

arch/arm/src/dm320/dm320_restart.S

@@ -110,7 +110,7 @@ up_phyrestart:
 	bic	r0, r0, #(CR_S|CR_I|CR_V|CR_RR)
 	mcr	p15, 0, r0, c1, c0, 0		/* Write control reg */
 
-	/* We know that the the bootloader entry point is at the
+	/* We know that the bootloader entry point is at the
 	 * beginning of flash.
 	 */
 #if 1

arch/arm/src/dm320/dm320_serial.c

@@ -587,7 +587,7 @@ static int up_ioctl(struct file *filep, int cmd, unsigned long arg)
  * Description:
  *   Called (usually) from the interrupt level to receive one
  *   character from the UART.  Error bits associated with the
- *   receipt are provided in the the return 'status'.
+ *   receipt are provided in the return 'status'.
  *
  ****************************************************************************/
 

arch/arm/src/imx/imx_serial.c

@@ -911,7 +911,7 @@ static int up_ioctl(struct file *filep, int cmd, unsigned long arg)
  * Description:
  *   Called (usually) from the interrupt level to receive one
  *   character from the UART.  Error bits associated with the
- *   receipt are provided in the the return 'status'.
+ *   receipt are provided in the return 'status'.
  *
  ****************************************************************************/
 

arch/arm/src/lm3s/lm3s_serial.c

@@ -674,7 +674,7 @@ static int up_ioctl(struct file *filep, int cmd, unsigned long arg)
  * Description:
  *   Called (usually) from the interrupt level to receive one
  *   character from the UART.  Error bits associated with the
- *   receipt are provided in the the return 'status'.
+ *   receipt are provided in the return 'status'.
  *
  ****************************************************************************/
 

arch/arm/src/lpc214x/lpc214x_serial.c

@@ -612,7 +612,7 @@ static int up_ioctl(struct file *filep, int cmd, unsigned long arg)
  * Description:
  *   Called (usually) from the interrupt level to receive one
  *   character from the UART.  Error bits associated with the
- *   receipt are provided in the the return 'status'.
+ *   receipt are provided in the return 'status'.
  *
  ****************************************************************************/
 

arch/arm/src/str71x/str71x_serial.c

@@ -783,7 +783,7 @@ static int up_ioctl(struct file *filep, int cmd, unsigned long arg)
  * Description:
  *   Called (usually) from the interrupt level to receive one
  *   character from the UART.  Error bits associated with the
- *   receipt are provided in the the return 'status'.
+ *   receipt are provided in the return 'status'.
  *
  ****************************************************************************/
 

arch/pjrc-8051/include/types.h

@@ -59,7 +59,7 @@
  * For SDCC, sizeof(int) is 16 and sizeof(long) is 32.
  * long long and double are not supported.
  *
- * Generic pointers are 3 bytes in length with the the
+ * Generic pointers are 3 bytes in length with the
  * first byte holding data space intformation.
  */
 

arch/pjrc-8051/src/up_blocktask.c

@@ -71,7 +71,7 @@
  *
  * Inputs:
  *   tcb: Refers to a task in the ready-to-run list (normally
- *     the task at the the head of the list).  It most be
+ *     the task at the head of the list).  It most be
  *     stopped, its context saved and moved into one of the
  *     waiting task lists.  It it was the task at the head
  *     of the ready-to-run list, then a context to the new

arch/pjrc-8051/src/up_exit.c

@@ -69,7 +69,7 @@
  *   This function causes the currently executing task to cease
  *   to exist.  This is a special case of task_delete() where the task to
  *   be deleted is the currently executing task.  It is more complex because
- *   a context switch must be perform to the the next ready to run task.
+ *   a context switch must be perform to the next ready to run task.
  *
  ****************************************************************************/
 

arch/sh/src/common/up_blocktask.c

@@ -71,7 +71,7 @@
  *
  * Inputs:
  *   tcb: Refers to a task in the ready-to-run list (normally
- *     the task at the the head of the list).  It most be
+ *     the task at the head of the list).  It most be
  *     stopped, its context saved and moved into one of the
  *     waiting task lists.  It it was the task at the head
  *     of the ready-to-run list, then a context to the new

arch/sh/src/common/up_exit.c

@@ -134,7 +134,7 @@ static void _up_dumponexit(FAR _TCB *tcb, FAR void *arg)
  *   This function causes the currently executing task to cease
  *   to exist.  This is a special case of task_delete() where the task to
  *   be deleted is the currently executing task.  It is more complex because
- *   a context switch must be perform to the the next ready to run task.
+ *   a context switch must be perform to the next ready to run task.
  *
  ****************************************************************************/
 

arch/sh/src/m16c/m16c_serial.c

@@ -906,7 +906,7 @@ static boolean up_rxavailable(struct uart_dev_s *dev)
 {
   struct up_dev_s *priv = (struct up_dev_s*)dev->priv;
 
-  /* Return true if the there is data available in the read buffer */
+  /* Return true if there is data available in the read buffer */
 
   return ((up_serialin(priv, M16C_UART_C1) & UART_C1_RI) != 0);
 }

arch/sh/src/m16c/m16c_sigdeliver.c

@@ -87,7 +87,7 @@ void up_sigdeliver(void)
   sig_deliver_t sigdeliver;
 
   /* Save the errno.  This must be preserved throughout the
-   * signal handling so that the the user code final gets
+   * signal handling so that the user code final gets
    * the correct errno value (probably EINTR).
    */
 

arch/sh/src/sh1/sh1_serial.c

@@ -644,7 +644,7 @@ static int up_interrupt(int irq, void *context)
  * Description:
  *   Called (usually) from the interrupt level to receive one
  *   character from the SCI.  Error bits associated with the
- *   receipt are provided in the the return 'status'.
+ *   receipt are provided in the return 'status'.
  *
  ****************************************************************************/
 

arch/sh/src/sh1/sh1_sigdeliver.c

@@ -87,7 +87,7 @@ void up_sigdeliver(void)
   sig_deliver_t sigdeliver;
 
   /* Save the errno.  This must be preserved throughout the
-   * signal handling so that the the user code final gets
+   * signal handling so that the user code final gets
    * the correct errno value (probably EINTR).
    */
 

arch/sim/src/up_blocktask.c

@@ -71,7 +71,7 @@
  *
  * Inputs:
  *   tcb: Refers to a task in the ready-to-run list (normally
- *     the task at the the head of the list).  It most be
+ *     the task at the head of the list).  It most be
  *     stopped, its context saved and moved into one of the
  *     waiting task lists.  It it was the task at the head
  *     of the ready-to-run list, then a context to the new

arch/sim/src/up_exit.c

@@ -68,7 +68,7 @@
  *   This function causes the currently executing task to cease
  *   to exist.  This is a special case of task_delete() where the task to
  *   be deleted is the currently executing task.  It is more complex because
- *   a context switch must be perform to the the next ready to run task.
+ *   a context switch must be perform to the next ready to run task.
  *
  ****************************************************************************/
 

arch/z16/include/z16f/irq.h

@@ -163,7 +163,7 @@
 
 #ifndef __ASSEMBLY__
 
-/* This is the the type of the register save array */
+/* This is the type of the register save array */
 
 typedef uint16 chipreg_t;
 

arch/z16/src/common/up_blocktask.c

@@ -74,7 +74,7 @@
  *
  * Inputs:
  *   tcb: Refers to a task in the ready-to-run list (normally
- *     the task at the the head of the list).  It most be
+ *     the task at the head of the list).  It most be
  *     stopped, its context saved and moved into one of the
  *     waiting task lists.  It it was the task at the head
  *     of the ready-to-run list, then a context to the new

arch/z16/src/common/up_exit.c

@@ -138,7 +138,7 @@ static void _up_dumponexit(FAR _TCB *tcb, FAR void *arg)
  *   This function causes the currently executing task to cease
  *   to exist.  This is a special case of task_delete() where the task to
  *   be deleted is the currently executing task.  It is more complex because
- *   a context switch must be perform to the the next ready to run task.
+ *   a context switch must be perform to the next ready to run task.
  *
  ****************************************************************************/
 

arch/z16/src/common/up_sigdeliver.c

@@ -87,7 +87,7 @@ void up_sigdeliver(void)
   sig_deliver_t sigdeliver;
 
   /* Save the errno.  This must be preserved throughout the signal handling
-   * so that the the user code final gets the correct errno value (probably
+   * so that the user code final gets the correct errno value (probably
    * EINTR).
    */
 

arch/z16/src/z16f/z16f_sysexec.c

@@ -89,7 +89,7 @@ void z16f_sysexec(FAR chipreg_t *regs)
 
   current_regs = regs;
  
-  /* The cause of the the system exception is indicated in the SYSEXCPH&L
+  /* The cause of the system exception is indicated in the SYSEXCPH&L
    * registers
    */
 

arch/z80/include/z8/irq.h

@@ -304,7 +304,7 @@
 
 #ifndef __ASSEMBLY__
 
-/* This is the the type of the register save array */
+/* This is the type of the register save array */
 
 typedef uint16 chipreg_t;
 

arch/z80/include/z80/irq.h

@@ -88,7 +88,7 @@
 
 #ifndef __ASSEMBLY__
 
-/* This is the the type of the register save array */
+/* This is the type of the register save array */
 
 typedef uint16 chipreg_t;
 

arch/z80/src/common/up_blocktask.c

@@ -75,7 +75,7 @@
  *
  * Inputs:
  *   tcb: Refers to a task in the ready-to-run list (normally
- *     the task at the the head of the list).  It most be
+ *     the task at the head of the list).  It most be
  *     stopped, its context saved and moved into one of the
  *     waiting task lists.  It it was the task at the head
  *     of the ready-to-run list, then a context to the new

arch/z80/src/common/up_exit.c

@@ -138,7 +138,7 @@ static void _up_dumponexit(FAR _TCB *tcb, FAR void *arg)
  *   This function causes the currently executing task to cease
  *   to exist.  This is a special case of task_delete() where the task to
  *   be deleted is the currently executing task.  It is more complex because
- *   a context switch must be perform to the the next ready to run task.
+ *   a context switch must be perform to the next ready to run task.
  *
  ****************************************************************************/
 

arch/z80/src/ez80/ez80_emac.c

@@ -2119,7 +2119,7 @@ int up_multicastfilter(FAR struct uip_driver_s *dev, FAR ubyte *mac, boolean ena
    * is '0', the multicast packet is rejected.
    */
 
-  /* Apply the hash algorithm to the the hash table index and bit number
+  /* Apply the hash algorithm to the hash table index and bit number
    * corresponding to this MAC
    */
 

arch/z80/src/ez80/ez80_sigdeliver.c

@@ -88,7 +88,7 @@ void up_sigdeliver(void)
   sig_deliver_t sigdeliver;
 
   /* Save the errno.  This must be preserved throughout the signal handling
-   * so that the the user code final gets the correct errno value (probably
+   * so that the user code final gets the correct errno value (probably
    * EINTR).
    */
 

arch/z80/src/z8/z8_sigdeliver.c

@@ -102,7 +102,7 @@ void up_sigdeliver(void)
   sig_deliver_t sigdeliver;
 
   /* Save the errno.  This must be preserved throughout the signal handling
-   * so that the the user code final gets the correct errno value (probably
+   * so that the user code final gets the correct errno value (probably
    * EINTR).
    */
 

arch/z80/src/z80/z80_sigdeliver.c

@@ -87,7 +87,7 @@ void up_sigdeliver(void)
   sig_deliver_t sigdeliver;
 
   /* Save the errno.  This must be preserved throughout the signal handling
-   * so that the the user code final gets the correct errno value (probably
+   * so that the user code final gets the correct errno value (probably
    * EINTR).
    */