sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

SAMA5 LCDC: Back out the delay kludge. Increase the LCDC input clock from MCK to 2*MCK was sufficient for all timing instbility problems

Browse Source
This commit is contained in:
Gregory Nutt 2014-07-12 11:24:14 -06:00
parent 4548ea731e
commit 3a6ea3642f
2 changed files with 0 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
arch/arm/src/sama5/sam_lcd.c
View File

@ -2973,18 +2973,6 @@ int up_fbinitialize(void)
sam_show_hcr();
#endif
#if defined(BOARD_LCDC_ENABLE_DELAY) && BOARD_LCDC_ENABLE_DELAY > 0
/* Delay a bit after enabling the LDC. I presume that a delay of a few
* frame times allows some unstable clocking to synchronize before we
* start thrashing the framebuffer? But I am not sure why this is
* necessary and, in fact, is certainly not necessary in most LCDC
* configurations. Perhaps this delay would not be necessary if timings
* were more precise?
*/
usleep(BOARD_LCDC_ENABLE_DELAY);
#endif
/* Enable the backlight.
*
* REVISIT: Backlight level could be dynamically adjustable

13
configs/sama5d4-ek/include/board.h
View File

@ -203,19 +203,6 @@
#define BOARD_LCDC_PIXELCLOCK \
(BOARD_LCDC_HSPERIOD * BOARD_LCDC_VSPERIOD * BOARD_LCDC_FRAMERATE)
/* This specifies a delay after enabling the LCDC. This was found
* experimentally and is very much a kludge. I presume that a delay of a
* couple of frame times allows some unstable clocking to synchronize before
* we start thrashing the framebuffer? But I am not sure why this is
* necessary and, in fact, is certainly not necessary in other LCDC
* configurations. Perhaps the delay would not be necessary if timings were
* more precise?
*
* Delays are in units of microseconds.
*/
#define BOARD_LCDC_ENABLE_DELAY (50*1000)
/* Backlight prescaler value and PWM output polarity */
#define BOARD_LCDC_PWMPS LCDC_LCDCFG6_PWMPS_DIV1