sergiotarxz/nuttx
sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sched: task_init as internal function shouldn't modify errno

Browse Source 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
This commit is contained in:
Xiang Xiao 2020-05-03 19:56:49 +08:00 committed by patacongo
parent 8d1a0c2761
commit 3c84278aa7
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
binfmt/binfmt_execmodule.c
View File

@ -170,7 +170,6 @@ int exec_module(FAR const struct binary_s *binp)
stack, binp->stacksize, binp->entrypt, binp->argv); stack, binp->stacksize, binp->entrypt, binp->argv);
if (ret < 0) if (ret < 0)
{ {
ret = -get_errno();
berr("task_init() failed: %d\n", ret); berr("task_init() failed: %d\n", ret);
kumm_free(stack); kumm_free(stack);
goto errout_with_addrenv; goto errout_with_addrenv;

10
sched/task/task_init.c
View File

@ -65,7 +65,7 @@
* parameters are required, argv may be NULL. * parameters are required, argv may be NULL.
* *
* Returned Value: * Returned Value:
* OK on success; ERROR on failure with errno set appropriately. (See * OK on success; negative error value on failure appropriately. (See
* nxtask_schedsetup() for possible failure conditions). On failure, the * nxtask_schedsetup() for possible failure conditions). On failure, the
* caller is responsible for freeing the stack memory and for calling * caller is responsible for freeing the stack memory and for calling
* sched_releasetcb() to free the TCB (which could be in most any state). * sched_releasetcb() to free the TCB (which could be in most any state).
@ -77,7 +77,6 @@ int task_init(FAR struct tcb_s *tcb, const char *name, int priority,
main_t entry, FAR char * const argv[]) main_t entry, FAR char * const argv[])
{ {
FAR struct task_tcb_s *ttcb = (FAR struct task_tcb_s *)tcb; FAR struct task_tcb_s *ttcb = (FAR struct task_tcb_s *)tcb;
int errcode;
int ret; int ret;
/* Only tasks and kernel threads can be initialized in this way */ /* Only tasks and kernel threads can be initialized in this way */
@ -92,7 +91,6 @@ int task_init(FAR struct tcb_s *tcb, const char *name, int priority,
ret = group_allocate(ttcb, tcb->flags); ret = group_allocate(ttcb, tcb->flags);
if (ret < 0) if (ret < 0)
{ {
errcode = -ret;
goto errout; goto errout;
} }
@ -101,7 +99,6 @@ int task_init(FAR struct tcb_s *tcb, const char *name, int priority,
ret = group_setuptaskfiles(ttcb); ret = group_setuptaskfiles(ttcb);
if (ret < 0) if (ret < 0)
{ {
errcode = -ret;
goto errout_with_group; goto errout_with_group;
} }
@ -115,7 +112,6 @@ int task_init(FAR struct tcb_s *tcb, const char *name, int priority,
TCB_FLAG_TTYPE_TASK); TCB_FLAG_TTYPE_TASK);
if (ret < OK) if (ret < OK)
{ {
errcode = -ret;
goto errout_with_group; goto errout_with_group;
} }
@ -128,7 +124,6 @@ int task_init(FAR struct tcb_s *tcb, const char *name, int priority,
ret = group_initialize(ttcb); ret = group_initialize(ttcb);
if (ret < 0) if (ret < 0)
{ {
errcode = -ret;
goto errout_with_group; goto errout_with_group;
} }
@ -138,6 +133,5 @@ errout_with_group:
group_leave(tcb); group_leave(tcb);
errout: errout:
set_errno(errcode); return ret;
return ERROR;
} }