sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update some comments

Browse Source
This commit is contained in:
Gregory Nutt 2015-04-13 07:39:56 -06:00
parent bf59ead547
commit 3d6161a7aa
2 changed files with 20 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
fs/fat/fs_fat32util.c
View File

@ -296,7 +296,10 @@ static int fat_checkbootrecord(struct fat_mountpt_s *fs)
uint16_t fat_getuint16(uint8_t *ptr)
{
/* Byte-by-byte transfer is still necessary if the address is un-aligned */
/* NOTE that (1) this operation is independent of endian-ness and that (2)
* byte-by-byte transfer is necessary in any case because the address may be
* unaligned.
*/
return ((uint16_t)ptr[1] << 8) | ptr[0];
}
@ -307,7 +310,10 @@ uint16_t fat_getuint16(uint8_t *ptr)
uint32_t fat_getuint32(uint8_t *ptr)
{
/* Byte-by-byte transfer is still necessary if the address is un-aligned */
/* NOTE that (1) this operation is independent of endian-ness and that (2)
* byte-by-byte transfer is necessary in any case because the address may be
* unaligned.
*/
return ((uint32_t)fat_getuint16(&ptr[2]) << 16) | fat_getuint16(&ptr[0]);
}
@ -321,13 +327,17 @@ void fat_putuint16(uint8_t *ptr, uint16_t value16)
uint8_t *val = (uint8_t*)&value16;
#ifdef CONFIG_ENDIAN_BIG
/* The bytes always have to be swapped if the target is big-endian */
/* If the target is big-endian then the bytes always have to be swapped so
* that the representation is litle endian in the file system.
*/
ptr[0] = val[1];
ptr[1] = val[0];
#else
/* Byte-by-byte transfer is still necessary if the address is un-aligned */
/* Byte-by-byte transfer is still necessary because the address may be
* un-aligned.
*/
ptr[0] = val[0];
ptr[1] = val[1];
@ -343,13 +353,17 @@ void fat_putuint32(uint8_t *ptr, uint32_t value32)
uint16_t *val = (uint16_t*)&value32;
#ifdef CONFIG_ENDIAN_BIG
/* The bytes always have to be swapped if the target is big-endian */
/* If the target is big-endian then the bytes always have to be swapped so
* that the representation is litle endian in the file system.
*/
fat_putuint16(&ptr[0], val[1]);
fat_putuint16(&ptr[2], val[0]);
#else
/* Byte-by-byte transfer is still necessary if the address is un-aligned */
/* Byte-by-byte transfer is still necessary because the address may be
* un-aligned.
*/
fat_putuint16(&ptr[0], val[0]);
fat_putuint16(&ptr[2], val[1]);

7
libc/Kconfig
View File

@ -274,13 +274,6 @@ config LIBC_LOCALTIME
timezone file is required for any another time zone and the environment
variable TZ must be set to the name of that file.
There is an issue with mktime being called very early in initialization
by the OS before there are any file systems available.
And finally, the times presented by the NSH date command are wrong when
this logic is enabled. I assume that this is due to some inconsistency
between the NuttX timing logic and the localtime timing logic.
if LIBC_LOCALTIME
config LIBC_TZ_MAX_TIMES