sergiotarxz/nuttx
sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

binnfmt:Fix return before close ELF fd

Browse Source 
elf_init open a elf file , if both enabled
   CONFIG_NSH_BUIlTAPPS and CONFIG_NSH_FILE_APPS ,
   elf_init will read elf file in /bin directory, but
   that length is zero , elf_read failed return and NOT
   close elf fd, so this line MUST be return to errout_with_init
This commit is contained in:
Liio Chen 2019-10-22 15:08:44 +08:00 committed by Xiang Xiao
parent e5f1069654
commit 468e08c1b4
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
binfmt/elf.c
View File

@ -220,7 +220,7 @@ static int elf_loadbinary(FAR struct binary_s *binp)
if (ret != 0)
{
berr("Failed to initialize for load of ELF program: %d\n", ret);
goto errout;
goto errout_with_init;
}
/* Load the program binary */
@ -287,7 +287,6 @@ errout_with_load:
elf_unload(&loadinfo);
errout_with_init:
elf_uninit(&loadinfo);
errout:
return ret;
}