sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

libc: Remove the redundant seek in writev

Browse Source 
since the file position isn't changed if write return fail

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
This commit is contained in:
Xiang Xiao 2022-04-29 02:53:40 +08:00 committed by Petro Karashchenko
parent 220f1dd6a0
commit 4a03cab6f9
1 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
libs/libc/uio/lib_writev.c
View File

@ -78,13 +78,8 @@ ssize_t writev(int fildes, FAR const struct iovec *iov, int iovcnt)
ssize_t nwritten; ssize_t nwritten;
size_t remaining; size_t remaining;
FAR uint8_t *buffer; FAR uint8_t *buffer;
off_t pos;
int i; int i;
/* Get the current file position in case we have to reset it */
pos = lseek(fildes, 0, SEEK_CUR);
/* Process each entry in the struct iovec array */ /* Process each entry in the struct iovec array */
for (i = 0, ntotal = 0; i < iovcnt; i++) for (i = 0, ntotal = 0; i < iovcnt; i++)
@ -108,21 +103,6 @@ ssize_t writev(int fildes, FAR const struct iovec *iov, int iovcnt)
if (nwritten < 0) if (nwritten < 0)
{ {
if (pos != (off_t)-1)
{
/* Save the errno value */
int save = get_errno();
/* Restore the file position */
lseek(fildes, pos, SEEK_SET);
/* Restore the errno value */
set_errno(save);
}
return ntotal ? ntotal : ERROR; return ntotal ? ntotal : ERROR;
} }