sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tools/zds/zdsar.c: Correct memory corruption bug

Browse Source 
A pointer to a string in a memory buffer was losing its value.  The reason was that the buffer was occasionally being used for other purposes.  The fix is to strdup() the string so that there is a private, protected copy.
This commit is contained in:
Gregory Nutt 2020-02-22 17:53:28 -06:00 committed by Abdelatif Guettouche
parent 738819b053
commit 4bf2a1ee91
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/zds/zdsar.c
View File

@ -384,7 +384,7 @@ static const char *convert_path(const char *path)
g_posixpath[size] = '"'; g_posixpath[size] = '"';
} }
g_posixpath[size+1] = '\0'; g_posixpath[size + 1] = '\0';
return retptr; return retptr;
#else #else
return path; return path;
@ -465,6 +465,8 @@ static void parse_args(int argc, char **argv)
} }
else if (strcmp(argv[argidx], "--library") == 0) else if (strcmp(argv[argidx], "--library") == 0)
{ {
const char *tmp_path;
argidx++; argidx++;
if (argidx >= argc) if (argidx >= argc)
{ {
@ -479,7 +481,13 @@ static void parse_args(int argc, char **argv)
* native mode. * native mode.
*/ */
library = (char *)convert_path(argv[argidx]); tmp_path = convert_path(argv[argidx]);
library = strdup(tmp_path);
if (library == NULL)
{
fprintf(stderr, "ERROR: strdup() failed\n");
exit(EXIT_FAILURE);
}
} }
else if (strcmp(argv[argidx], "--obj-path") == 0) else if (strcmp(argv[argidx], "--obj-path") == 0)
{ {