From 50aa1e09393946d0e107896c089e572b662709ae Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Tue, 7 Apr 2015 12:16:15 -0600 Subject: [PATCH] Modbus: Misc cleanup --- TODO | 44 +++++++++++++++++++++++----- configs/cloudctrl/nsh/defconfig | 2 +- configs/samv71-xult/README.txt | 13 ++++---- configs/samv71-xult/src/atmxt-xpro.h | 2 +- 4 files changed, 47 insertions(+), 14 deletions(-) diff --git a/TODO b/TODO index 421cc3483e..d451b6d2d3 100644 --- a/TODO +++ b/TODO @@ -9,17 +9,17 @@ board port. nuttx/ (11) Task/Scheduler (sched/) - (1) Memory Managment (mm/) + (1) Memory Management (mm/) (3) Signals (sched/signal, arch/) (2) pthreads (sched/pthread) (0) Message Queues (sched/mqueue) (4) C++ Support (6) Binary loaders (binfmt/) - (11) Network (net/, drivers/net) + (12) Network (net/, drivers/net) (4) USB (drivers/usbdev, drivers/usbhost) (12) Libraries (libc/, libm/) (11) File system/Generic drivers (fs/, drivers/) - (8) Graphics subystem (graphics/) + (8) Graphics subsystem (graphics/) (1) Pascal add-on (pcode/) (2) Build system / Toolchains (3) Linux/Cywgin simulation (arch/sim) @@ -306,7 +306,7 @@ o Signals (sched/signal, arch/) (e.g., SIGINT, SIGSEGV, etc). Update: SIGCHLD is supported if so configured. - Status: Open. No changes are planned. + Status: Open. No further changes are planned. Priority: Low, required by standards but not so critical for an embedded system. @@ -336,7 +336,7 @@ o pthreads (sched/pthreads) Priority: Low, probably not that useful Title: PTHREAD_PRIO_PROTECT - Description: Extended pthread_mutexattr_setprotocol() suport PTHREAD_PRIO_PROTECT: + Description: Extended pthread_mutexattr_setprotocol() support PTHREAD_PRIO_PROTECT: "When a thread owns one or more mutexes initialized with the PTHREAD_PRIO_PROTECT protocol, it shall execute at the higher of its priority or the highest of the priority ceilings of all the mutexes @@ -800,8 +800,20 @@ o Network (net/, drivers/net) Title: STANDARDIZE ETHERNET DRIVER STATISTICS Description: Need to standardize collection of statistics from network - drivers. apps/nshlib ifconfig command should present - statistics. + drivers. Currently they are useless because they are not + accessible. The solution is to standardize the structure + that holds the drivers statistics. Then apps/nshlib + ifconfig command could present the driver statistics. + + Currently these drivers support non-standard statistics: + + arch/arm/src/kinetis/kinetis_enet.c + arch/arm/src/lpc17xx/lpc17_ethernet.c + arch/arm/src/tiva/lm3s_ethernet.c + arch/mips/src/pic32mx/pic32mx-ethernet.c + arch/z80/src/ez80/ez80_emac.c + + The other Ethernet drivers support no statistics. Status: Open Priority: Low. This is not a bug but an enhancement idea. @@ -956,6 +968,24 @@ o Network (net/, drivers/net) In that case you would effectively have a memory leak and the number of FIFO instances grow. + Title: TCP IPv4-MAPPED IPv6 ADDRESSES + Description: The UDP implementation in net/udp contains support for Hybrid + dual-stack IPv6/IPv4 implementations that utilize a special + class of addresses, the IPv4-mapped IPv6 addresses. You can + see that UDP implementation in: + + udp_callback.c: + ip6_map_ipv4addr(ipv4addr, + udp_send.c: + ip6_is_ipv4addr((FAR struct in6_addr*)conn->u.ipv6.raddr))) + ip6_is_ipv4addr((FAR struct in6_addr*)conn->u.ipv6.raddr)) + in_addr_t raddr = ip6_get_ipv4addr((FAR struct in6_addr*)conn->u.ipv6.raddr); + + There is no corresponding support for TCP sockets. + Status: Open + Priority: Low. I don't know of any issues now, but I am sure that + someone will encounter this in the future. + o USB (drivers/usbdev, drivers/usbhost) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ diff --git a/configs/cloudctrl/nsh/defconfig b/configs/cloudctrl/nsh/defconfig index 090e62b47f..f6247a3c80 100644 --- a/configs/cloudctrl/nsh/defconfig +++ b/configs/cloudctrl/nsh/defconfig @@ -593,7 +593,7 @@ CONFIG_PTHREAD_STACK_DEFAULT=2048 # # Device Drivers # -CONFIG_DISABLE_POLL=y +# CONFIG_DISABLE_POLL is not set CONFIG_DEV_NULL=y # CONFIG_DEV_ZERO is not set # CONFIG_LOOP is not set diff --git a/configs/samv71-xult/README.txt b/configs/samv71-xult/README.txt index a9209f1b14..778efad644 100644 --- a/configs/samv71-xult/README.txt +++ b/configs/samv71-xult/README.txt @@ -118,11 +118,14 @@ The BASIC nsh configuration is fully function (as desribed below under However, the maXTouch touchscreen driver is not working. I tried re- using the maXTouch driver that was used with the SAMA5D4-EK TM7000 - LCD, but the maXTouch Xplained Pro has a different maXTouch part. - The driver claims that all operations are success, but there are no - interrupts signalling touch event. I assume that the different - maXTouch part is not being configured correctly but there is no - avaiable technical documentation or sample code to debug with. + LCD, but the maXTouch Xplained Pro has a different maXTouch part + (ATMXT112S). No data sheet is available for this part. + + The existing maXTouch driver claims that all operations on the ATMXT112S + are success, but there are no interrupts signalling touch event. I + assume that the different maXTouch part is not being configured + correctly but there is no available technical documentation or sample + code to debug with. Serial Console ============== diff --git a/configs/samv71-xult/src/atmxt-xpro.h b/configs/samv71-xult/src/atmxt-xpro.h index aa9cc92720..50143a94f2 100644 --- a/configs/samv71-xult/src/atmxt-xpro.h +++ b/configs/samv71-xult/src/atmxt-xpro.h @@ -49,7 +49,7 @@ #define HAVE_MAXTOUCH 1 #define HAVE_ILI9488_SMC 1 -#undef HAVE_ILI9488_SPI /* Not yet suppported */ +#undef HAVE_ILI9488_SPI /* Not yet suppported */ /* maXTouch and LCD only available if the maXTouch Xplained Pro is connected */