sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

kthread_create(): Rename kernel_thread() to kthread_create() for better naming consistency with task_create() and kthread_delete().

Browse Source
This commit is contained in:
Gregory Nutt 2017-10-16 11:38:00 -06:00
parent b1a41b7620
commit 5b385f4d4d
18 changed files with 93 additions and 70 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
TODO
View File

@ -716,9 +716,10 @@ o Kernel/Protected Build
Obviously system performance could be improved greatly by simply
optimizing these functions so that they do not need to system calls
so frequently. getpid() is (I believe) part of the re-entrant
semaphore logic. Something like TLS might be used to retain the
thread's ID locally.
so frequently. This getpid() call is part of the re-entrant
semaphore logic used with printf() and other C buffered I/O.
Something like TLS might be used to retain the thread's ID
locally.
Linux, for example, has functions call up() and down(). up()
increments the semaphore count but does not call into the kernel
@ -727,11 +728,11 @@ o Kernel/Protected Build
the count becomes negative the caller must be blocked.
Update:
"I am thinking that there should be a "magic" global, user-accessible
variable that holds the PID of the currently executing thread;
basically the PID of the task at the head of the ready-to-run list.
This variable would have to be reset each time the head of the ready-
to-run list changes.
"I am thinking that there should be a "magic" global, user-
accessible variable that holds the PID of the currently
executing thread; basically the PID of the task at the head
of the ready-to-run list. This variable would have to be reset
each time the head of the ready-to-run list changes.
"Then getpid() could be implemented in user space with no system call
by simply reading this variable.
@ -749,6 +750,21 @@ o Kernel/Protected Build
Update:
One solution might be to used CONFIG_TLS, add the PID to struct
tls_info_s. Then the PID could be obtained without a system call.
TLS is not very useful in the FLAT build, however. TLS works by
putting per-thread data at the bottom of an aligned stack. The
current stack pointer is the ANDed with the alignment mask to
obtain the per-thread data address.
There are problems with this in the FLAT and PROTECTED builds:
First the maximum size of the stack is limited by the number
of bits in the mask. This means that you need to have a very
high alignment to support tasks with large stacks. But
secondly, the higher the alignment of the stacks stacks, the
more memory is lost to fragmentation.
In the KERNEL build, the the stack lies at a virtual address
and it is possible to have highly aligned stacks with no such
penalties.
Status: Open
Priority: Low-Medium. Right now, I do not know if these syscalls are a
real performance issue or not. The above statistics were collected
@ -798,6 +814,10 @@ o Kernel/Protected Build
might also want to be able to modify privileged threads from
user tasks with certain permissions. Permissions is a much
more complex issue.
task_delete(), for example, is not permitted to kill a kernel
thread. But should not a privileged user task be able to do
so?
Status: Open
Priority: Low for most embedded systems but would be a critical need if
NuttX were used in a secure system.

8
configs/photon/src/stm32_wdt.c
View File

@ -158,10 +158,10 @@ int photon_watchdog_initialize(void)
/* Spawn wdog deamon thread */
int taskid = kernel_thread(CONFIG_PHOTON_WDG_THREAD_NAME,
CONFIG_PHOTON_WDG_THREAD_PRIORITY,
CONFIG_PHOTON_WDG_THREAD_STACKSIZE,
(main_t)wdog_daemon, (FAR char * const *)NULL);
int taskid = kthread_create(CONFIG_PHOTON_WDG_THREAD_NAME,
CONFIG_PHOTON_WDG_THREAD_PRIORITY,
CONFIG_PHOTON_WDG_THREAD_STACKSIZE,
(main_t)wdog_daemon, (FAR char * const *)NULL);
if (taskid <= 0)
{

8
configs/sam4s-xplained-pro/src/sam_wdt.c
View File

@ -192,10 +192,10 @@ int sam_watchdog_initialize(void)
#if defined(CONFIG_WDT_THREAD)
sched_lock();
int taskid = kernel_thread(CONFIG_WDT_THREAD_NAME,
CONFIG_WDT_THREAD_PRIORITY,
CONFIG_WDT_THREAD_STACKSIZE,
(main_t)wdog_daemon, (FAR char * const *)NULL);
int taskid = kthread_create(CONFIG_WDT_THREAD_NAME,
CONFIG_WDT_THREAD_PRIORITY,
CONFIG_WDT_THREAD_STACKSIZE,
(main_t)wdog_daemon, (FAR char * const *)NULL);
ASSERT(taskid > 0);
sched_unlock();

6
configs/stm3240g-eval/src/stm32_boot.c
View File

@ -252,9 +252,9 @@ void board_initialize(void)
/* Start the board initialization kernel thread */
server = kernel_thread("Board Init", CONFIG_STM3240G_BOARDINIT_PRIO,
CONFIG_STM3240G_BOARDINIT_STACK, board_initthread,
NULL);
server = kthread_create("Board Init", CONFIG_STM3240G_BOARDINIT_PRIO,
CONFIG_STM3240G_BOARDINIT_STACK, board_initthread,
NULL);
ASSERT(server > 0);
#else
(void)stm32_bringup();

8
drivers/usbdev/usbmsc.c
View File

@ -1704,9 +1704,9 @@ int usbmsc_exportluns(FAR void *handle)
g_usbmsc_handoff = priv;
uinfo("Starting SCSI worker thread\n");
priv->thpid = kernel_thread("scsid", CONFIG_USBMSC_SCSI_PRIO,
CONFIG_USBMSC_SCSI_STACKSIZE,
usbmsc_scsi_main, NULL);
priv->thpid = kthread_create("scsid", CONFIG_USBMSC_SCSI_PRIO,
CONFIG_USBMSC_SCSI_STACKSIZE,
usbmsc_scsi_main, NULL);
if (priv->thpid <= 0)
{
usbtrace(TRACE_CLSERROR(USBMSC_TRACEERR_THREADCREATE),
@ -1960,4 +1960,4 @@ void usbmsc_get_composite_devdesc(FAR struct composite_devdesc_s *dev)
dev->devinfo.nendpoints = USBMSC_NENDPOINTS;
}
#endif
#endif

9
drivers/usbhost/usbhost_hidkbd.c
View File

@ -1613,7 +1613,7 @@ static inline int usbhost_devinit(FAR struct usbhost_state_s *priv)
uinfo("Start poll task\n");
/* The inputs to a task started by kernel_thread() are very awkard for this
/* The inputs to a task started by kthread_create() are very awkard for this
* purpose. They are really designed for command line tasks (argc/argv). So
* the following is kludge pass binary data when the keyboard poll task
* is started.
@ -1625,9 +1625,10 @@ static inline int usbhost_devinit(FAR struct usbhost_state_s *priv)
usbhost_takesem(&g_exclsem);
g_priv = priv;
priv->pollpid = kernel_thread("kbdpoll", CONFIG_HIDKBD_DEFPRIO,
CONFIG_HIDKBD_STACKSIZE,
(main_t)usbhost_kbdpoll, (FAR char * const *)NULL);
priv->pollpid = kthread_create("kbdpoll", CONFIG_HIDKBD_DEFPRIO,
CONFIG_HIDKBD_STACKSIZE,
(main_t)usbhost_kbdpoll,
(FAR char * const *)NULL);
if (priv->pollpid == ERROR)
{
/* Failed to started the poll thread... probably due to memory resources */

9
drivers/usbhost/usbhost_hidmouse.c
View File

@ -1683,7 +1683,7 @@ static inline int usbhost_devinit(FAR struct usbhost_state_s *priv)
uinfo("Start poll task\n");
/* The inputs to a task started by kernel_thread() are very awkward for this
/* The inputs to a task started by kthread_create() are very awkward for this
* purpose. They are really designed for command line tasks (argc/argv). So
* the following is kludge pass binary data when the mouse poll task
* is started.
@ -1695,9 +1695,10 @@ static inline int usbhost_devinit(FAR struct usbhost_state_s *priv)
usbhost_takesem(&g_exclsem);
g_priv = priv;
priv->pollpid = kernel_thread("mouse", CONFIG_HIDMOUSE_DEFPRIO,
CONFIG_HIDMOUSE_STACKSIZE,
(main_t)usbhost_mouse_poll, (FAR char * const *)NULL);
priv->pollpid = kthread_create("mouse", CONFIG_HIDMOUSE_DEFPRIO,
CONFIG_HIDMOUSE_STACKSIZE,
(main_t)usbhost_mouse_poll,
(FAR char * const *)NULL);
if (priv->pollpid == ERROR)
{
/* Failed to started the poll thread... probably due to memory resources */

9
drivers/usbhost/usbhost_xboxcontroller.c
View File

@ -1324,7 +1324,7 @@ static inline int usbhost_devinit(FAR struct usbhost_state_s *priv)
* memory resources, primarily for the dedicated stack (CONFIG_XBOXCONTROLLER_STACKSIZE).
*/
/* The inputs to a task started by kernel_thread() are very awkward for this
/* The inputs to a task started by kthread_create() are very awkward for this
* purpose. They are really designed for command line tasks (argc/argv). So
* the following is kludge pass binary data when the controller poll task
* is started.
@ -1337,9 +1337,10 @@ static inline int usbhost_devinit(FAR struct usbhost_state_s *priv)
g_priv = priv;
uinfo("Starting thread\n");
priv->pollpid = kernel_thread("xbox", CONFIG_XBOXCONTROLLER_DEFPRIO,
CONFIG_XBOXCONTROLLER_STACKSIZE,
(main_t)usbhost_xboxcontroller_poll, (FAR char * const *)NULL);
priv->pollpid = kthread_create("xbox", CONFIG_XBOXCONTROLLER_DEFPRIO,
CONFIG_XBOXCONTROLLER_STACKSIZE,
(main_t)usbhost_xboxcontroller_poll,
(FAR char * const *)NULL);
if (priv->pollpid == ERROR)
{
/* Failed to started the poll thread... probably due to memory resources */

8
drivers/usbmonitor/usbmonitor.c
View File

@ -225,10 +225,10 @@ int usbmonitor_start(void)
g_usbmonitor.started = true;
g_usbmonitor.stop = false;
ret = kernel_thread("USB Monitor", CONFIG_USBMONITOR_PRIORITY,
CONFIG_USBMONITOR_STACKSIZE,
(main_t)usbmonitor_daemon,
(FAR char * const *)NULL);
ret = kthread_create("USB Monitor", CONFIG_USBMONITOR_PRIORITY,
CONFIG_USBMONITOR_STACKSIZE,
(main_t)usbmonitor_daemon,
(FAR char * const *)NULL);
if (ret < 0)
{
int errcode = errno;

6
drivers/wireless/ieee80211/bcmf_sdio.c
View File

@ -670,9 +670,9 @@ int bcmf_bus_sdio_initialize(FAR struct bcmf_dev_s *priv,
/* Spawn bcmf daemon thread */
ret = kernel_thread(BCMF_THREAD_NAME, SCHED_PRIORITY_MAX,
BCMF_THREAD_STACK_SIZE, bcmf_sdio_thread,
(FAR char * const *)NULL);
ret = kthread_create(BCMF_THREAD_NAME, SCHED_PRIORITY_MAX,
BCMF_THREAD_STACK_SIZE, bcmf_sdio_thread,
(FAR char * const *)NULL);
if (ret <= 0)
{

4
graphics/nxmu/nx_start.c
View File

@ -191,8 +191,8 @@ int nx_start(void)
/* Start the server kernel thread */
ginfo("Starting server task\n");
server = kernel_thread("NX Server", CONFIG_NXSTART_SERVERPRIO,
CONFIG_NXSTART_SERVERSTACK, nx_server, NULL);
server = kthread_create("NX Server", CONFIG_NXSTART_SERVERPRIO,
CONFIG_NXSTART_SERVERSTACK, nx_server, NULL);
if (server < 0)
{
int errcode = errno;

2
graphics/vnc/server/vnc_fbdev.c
View File

@ -452,7 +452,7 @@ static int vnc_start_server(int display)
argv[0] = str;
argv[1] = NULL;
pid = kernel_thread("vnc_server", CONFIG_VNCSERVER_PRIO,
pid = kthread_create("vnc_server", CONFIG_VNCSERVER_PRIO,
CONFIG_VNCSERVER_STACKSIZE,
(main_t)vnc_server, argv);
if (pid < 0)

6
include/nuttx/kthread.h
View File

@ -65,7 +65,7 @@ extern "C"
****************************************************************************/
/********************************************************************************
* Name: kernel_thread
* Name: kthread_create
*
* Description:
* This function creates and activates a kernel thread task with kernel-mode
@ -80,8 +80,8 @@ extern "C"
*
********************************************************************************/
int kernel_thread(FAR const char *name, int priority, int stack_size,
main_t entry, FAR char * const argv[]);
int kthread_create(FAR const char *name, int priority, int stack_size,
main_t entry, FAR char * const argv[]);
/****************************************************************************
* Name: kthread_delete

8
sched/init/os_bringup.c
View File

@ -154,9 +154,9 @@ static inline void os_pgworker(void)
sinfo("Starting paging thread\n");
g_pgworker = kernel_thread("pgfill", CONFIG_PAGING_DEFPRIO,
CONFIG_PAGING_STACKSIZE,
(main_t)pg_worker, (FAR char * const *)NULL);
g_pgworker = kthread_create("pgfill", CONFIG_PAGING_DEFPRIO,
CONFIG_PAGING_STACKSIZE,
(main_t)pg_worker, (FAR char * const *)NULL);
DEBUGASSERT(g_pgworker > 0);
}
@ -354,7 +354,7 @@ static inline void os_start_application(void)
* execution.
*/
pid = kernel_thread("AppBringUp", CONFIG_BOARD_INITTHREAD_PRIORITY,
pid = kthread_create("AppBringUp", CONFIG_BOARD_INITTHREAD_PRIORITY,
CONFIG_BOARD_INITTHREAD_STACKSIZE,
(main_t)os_start_task, (FAR char * const *)NULL);
ASSERT(pid > 0);

8
sched/task/task_create.c
View File

@ -62,7 +62,7 @@
* Description:
* This function creates and activates a new thread of the specified type
* with a specified priority and returns its system-assigned ID. It is the
* internal, common implementation of task_create() and kernel_thread().
* internal, common implementation of task_create() and kthread_create().
* See comments with task_create() for further information.
*
* Input Parameters:
@ -243,7 +243,7 @@ int task_create(FAR const char *name, int priority,
#endif
/****************************************************************************
* Name: kernel_thread
* Name: kthread_create
*
* Description:
* This function creates and activates a kernel thread task with kernel-
@ -258,8 +258,8 @@ int task_create(FAR const char *name, int priority,
*
****************************************************************************/
int kernel_thread(FAR const char *name, int priority,
int stack_size, main_t entry, FAR char *const argv[])
int kthread_create(FAR const char *name, int priority,
int stack_size, main_t entry, FAR char *const argv[])
{
return thread_create(name, TCB_FLAG_TTYPE_KERNEL, priority, stack_size,
entry, argv);

8
sched/task/task_posixspawn.c
View File

@ -414,10 +414,10 @@ int posix_spawn(FAR pid_t *pid, FAR const char *path,
* task.
*/
proxy = kernel_thread("posix_spawn_proxy", param.sched_priority,
CONFIG_POSIX_SPAWN_PROXY_STACKSIZE,
(main_t)posix_spawn_proxy,
(FAR char * const *)NULL);
proxy = kthread_create("posix_spawn_proxy", param.sched_priority,
CONFIG_POSIX_SPAWN_PROXY_STACKSIZE,
(main_t)posix_spawn_proxy,
(FAR char * const *)NULL);
if (proxy < 0)
{
ret = get_errno();

10
sched/wqueue/kwork_hpthread.c
View File

@ -154,10 +154,10 @@ int work_hpstart(void)
sinfo("Starting high-priority kernel worker thread\n");
pid = kernel_thread(HPWORKNAME, CONFIG_SCHED_HPWORKPRIORITY,
CONFIG_SCHED_HPWORKSTACKSIZE,
(main_t)work_hpthread,
(FAR char * const *)NULL);
pid = kthread_create(HPWORKNAME, CONFIG_SCHED_HPWORKPRIORITY,
CONFIG_SCHED_HPWORKSTACKSIZE,
(main_t)work_hpthread,
(FAR char * const *)NULL);
DEBUGASSERT(pid > 0);
if (pid < 0)
@ -165,7 +165,7 @@ int work_hpstart(void)
int errcode = errno;
DEBUGASSERT(errcode > 0);
serr("ERROR: kernel_thread failed: %d\n", errcode);
serr("ERROR: kthread_create failed: %d\n", errcode);
return -errcode;
}

10
sched/wqueue/kwork_lpthread.c
View File

@ -201,10 +201,10 @@ int work_lpstart(void)
for (wndx = 0; wndx < CONFIG_SCHED_LPNTHREADS; wndx++)
{
pid = kernel_thread(LPWORKNAME, CONFIG_SCHED_LPWORKPRIORITY,
CONFIG_SCHED_LPWORKSTACKSIZE,
(main_t)work_lpthread,
(FAR char * const *)NULL);
pid = kthread_create(LPWORKNAME, CONFIG_SCHED_LPWORKPRIORITY,
CONFIG_SCHED_LPWORKSTACKSIZE,
(main_t)work_lpthread,
(FAR char * const *)NULL);
DEBUGASSERT(pid > 0);
if (pid < 0)
@ -212,7 +212,7 @@ int work_lpstart(void)
int errcode = errno;
DEBUGASSERT(errcode > 0);
serr("ERROR: kernel_thread %d failed: %d\n", wndx, errcode);
serr("ERROR: kthread_create %d failed: %d\n", wndx, errcode);
sched_unlock();
return -errcode;
}