From 5eb08a4b33344f810996b624f3dab312ba72c523 Mon Sep 17 00:00:00 2001 From: Zhe Weng Date: Tue, 23 Jan 2024 16:52:30 +0800 Subject: [PATCH] net: Fix minor coding problems Fix minor problems when reading codes: - icmpv6_autoconfig: Call net_unlock before return - pkt_sendmsg: Return error for types other than SOCK_RAW Signed-off-by: Zhe Weng --- net/icmpv6/icmpv6_autoconfig.c | 1 + net/pkt/pkt_sendmsg.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/net/icmpv6/icmpv6_autoconfig.c b/net/icmpv6/icmpv6_autoconfig.c index ec8adecaad..16cfce0d79 100644 --- a/net/icmpv6/icmpv6_autoconfig.c +++ b/net/icmpv6/icmpv6_autoconfig.c @@ -363,6 +363,7 @@ int icmpv6_autoconfig(FAR struct net_driver_s *dev) ret = netdev_ipv6_add(dev, lladdr, net_ipv6_mask2pref(g_ipv6_llnetmask)); if (ret < 0) { + net_unlock(); return ret; } diff --git a/net/pkt/pkt_sendmsg.c b/net/pkt/pkt_sendmsg.c index 08ed662c52..1ff6f0eef2 100644 --- a/net/pkt/pkt_sendmsg.c +++ b/net/pkt/pkt_sendmsg.c @@ -194,7 +194,7 @@ ssize_t pkt_sendmsg(FAR struct socket *psock, FAR struct msghdr *msg, /* Only SOCK_RAW is supported */ - if (psock->s_type == SOCK_RAW) + if (psock->s_type != SOCK_RAW) { /* EDESTADDRREQ. Signifies that the socket is not connection-mode and * no peer address is set.