From 5f7cc0462706bebf7298850bc38f9bf9598a6373 Mon Sep 17 00:00:00 2001 From: Xiang Xiao Date: Sat, 30 Oct 2021 21:39:46 +0800 Subject: [PATCH] fs/aio: Fix compile warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit aio/lio_listio.c:227:7: warning: implicit declaration of function ‘ferr’ [-Wimplicit-function-declaration] 227 | ferr("ERROR: lib_zalloc failed\n"); | ^~~~ aio/lio_listio.c:275:3: warning: implicit declaration of function ‘finfo’ [-Wimplicit-function-declaration] 275 | finfo("Registering signal handler\n"); aio/aio_read.c: In function ‘aio_read_worker’: aio/aio_read.c:90:11: warning: implicit declaration of function ‘file_pread’; did you mean ‘aio_read’? [-Wimplicit-function-declaration] 90 | nread = file_pread(aioc->aioc_filep, (FAR void *)aiocbp->aio_buf, | ^~~~~~~~~~ | aio_read aio/aio_write.c: In function ‘aio_write_worker’: aio/aio_write.c:85:12: warning: implicit declaration of function ‘file_fcntl’ [-Wimplicit-function-declaration] 85 | oflags = file_fcntl(aioc->aioc_filep, F_GETFL); | ^~~~~~~~~~ CC: mmap/fs_mmap.c CC: pthread/pthread_condclockwait.c aio/aio_write.c:107:18: warning: implicit declaration of function ‘file_write’; did you mean ‘aio_write’? [-Wimplicit-function-declaration] 107 | nwritten = file_write(aioc->aioc_filep, | ^~~~~~~~~~ | aio_write aio/aio_write.c:113:18: warning: implicit declaration of function ‘file_pwrite’; did you mean ‘aio_write’? [-Wimplicit-function-declaration] 113 | nwritten = file_pwrite(aioc->aioc_filep, | ^~~~~~~~~~~ | aio_write In file included from aio/aio_write.c:34: aio/aio_write.c:121:12: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘ssize_t’ {aka ‘long int’} [-Wformat=] 121 | ferr("ERROR: write/pwrite/send failed: %d\n", nwritten); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~ | | | ssize_t {aka long int} aio/aio_write.c:121:47: note: format string is defined here 121 | ferr("ERROR: write/pwrite/send failed: %d\n", nwritten); | ~^ | | | int | %ld Signed-off-by: Xiang Xiao --- fs/aio/aio_read.c | 1 + fs/aio/aio_write.c | 4 +++- libs/libc/aio/lio_listio.c | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/aio/aio_read.c b/fs/aio/aio_read.c index 0f5fd8ab59..dad4f0c301 100644 --- a/fs/aio/aio_read.c +++ b/fs/aio/aio_read.c @@ -31,6 +31,7 @@ #include #include +#include #include #include "aio/aio.h" diff --git a/fs/aio/aio_write.c b/fs/aio/aio_write.c index 435275460a..c09cebcd0d 100644 --- a/fs/aio/aio_write.c +++ b/fs/aio/aio_write.c @@ -33,6 +33,8 @@ #include #include +#include + #include "aio/aio.h" #ifdef CONFIG_FS_AIO @@ -118,7 +120,7 @@ static void aio_write_worker(FAR void *arg) if (nwritten < 0) { - ferr("ERROR: write/pwrite/send failed: %d\n", nwritten); + ferr("ERROR: write/pwrite/send failed: %zd\n", nwritten); } /* Save the result of the write */ diff --git a/libs/libc/aio/lio_listio.c b/libs/libc/aio/lio_listio.c index 29042f1ef5..35a8d7a988 100644 --- a/libs/libc/aio/lio_listio.c +++ b/libs/libc/aio/lio_listio.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include