From 607ff7d2fbd4d5e69334384e46bc41b32877d9cc Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Sun, 3 May 2015 16:45:44 -0600 Subject: [PATCH] Update some READMEs. For all implementation of the USBHOST waiter, make sure that the waiter thread stack size is larger if the USB hub feature is enabled --- configs/cloudctrl/src/stm32_usb.c | 6 +++++- configs/ea3131/src/lpc31_usbhost.c | 6 +++++- configs/mikroe-stm32f4/src/stm32_usb.c | 6 +++++- configs/olimex-lpc-h3131/src/lpc31_usbhost.c | 6 +++++- configs/olimex-lpc1766stk/README.txt | 11 +++-------- configs/olimex-stm32-p207/src/stm32_usb.c | 6 +++++- configs/open1788/src/lpc17_nsh.c | 6 +++++- configs/pic32mx-starterkit/src/pic32mx_nsh.c | 6 +++++- configs/pic32mx7mmb/src/pic32_nsh.c | 6 +++++- configs/sama5d3x-ek/README.txt | 2 +- configs/shenzhou/src/stm32_usb.c | 6 +++++- configs/stm3220g-eval/src/stm32_usb.c | 6 +++++- configs/stm3240g-eval/src/stm32_usb.c | 6 +++++- configs/sure-pic32mx/src/pic32mx_nsh.c | 6 +++++- 14 files changed, 64 insertions(+), 21 deletions(-) diff --git a/configs/cloudctrl/src/stm32_usb.c b/configs/cloudctrl/src/stm32_usb.c index fd99035c45..337bb998cd 100644 --- a/configs/cloudctrl/src/stm32_usb.c +++ b/configs/cloudctrl/src/stm32_usb.c @@ -75,7 +75,11 @@ #endif #ifndef CONFIG_USBHOST_STACKSIZE -# define CONFIG_USBHOST_STACKSIZE 1024 +# ifdef CONFIG_USBHOST_HUB +# define CONFIG_USBHOST_STACKSIZE 1536 +# else +# define CONFIG_USBHOST_STACKSIZE 1024 +# endif #endif /************************************************************************************ diff --git a/configs/ea3131/src/lpc31_usbhost.c b/configs/ea3131/src/lpc31_usbhost.c index 78597a09b7..d2eefb11d7 100644 --- a/configs/ea3131/src/lpc31_usbhost.c +++ b/configs/ea3131/src/lpc31_usbhost.c @@ -67,7 +67,11 @@ #endif #ifndef CONFIG_USBHOST_STACKSIZE -# define CONFIG_USBHOST_STACKSIZE 1024 +# ifdef CONFIG_USBHOST_HUB +# define CONFIG_USBHOST_STACKSIZE 1536 +# else +# define CONFIG_USBHOST_STACKSIZE 1024 +# endif #endif /************************************************************************************ diff --git a/configs/mikroe-stm32f4/src/stm32_usb.c b/configs/mikroe-stm32f4/src/stm32_usb.c index 31ee93f92c..1b0df8cedf 100644 --- a/configs/mikroe-stm32f4/src/stm32_usb.c +++ b/configs/mikroe-stm32f4/src/stm32_usb.c @@ -74,7 +74,11 @@ #endif #ifndef CONFIG_USBHOST_STACKSIZE -# define CONFIG_USBHOST_STACKSIZE 1024 +# ifdef CONFIG_USBHOST_HUB +# define CONFIG_USBHOST_STACKSIZE 1536 +# else +# define CONFIG_USBHOST_STACKSIZE 1024 +# endif #endif /************************************************************************************ diff --git a/configs/olimex-lpc-h3131/src/lpc31_usbhost.c b/configs/olimex-lpc-h3131/src/lpc31_usbhost.c index f3699e2224..1d876a1b89 100644 --- a/configs/olimex-lpc-h3131/src/lpc31_usbhost.c +++ b/configs/olimex-lpc-h3131/src/lpc31_usbhost.c @@ -67,7 +67,11 @@ #endif #ifndef CONFIG_USBHOST_STACKSIZE -# define CONFIG_USBHOST_STACKSIZE 1024 +# ifdef CONFIG_USBHOST_HUB +# define CONFIG_USBHOST_STACKSIZE 1536 +# else +# define CONFIG_USBHOST_STACKSIZE 1024 +# endif #endif /************************************************************************************ diff --git a/configs/olimex-lpc1766stk/README.txt b/configs/olimex-lpc1766stk/README.txt index 5a3a47fd2b..d33edecb03 100644 --- a/configs/olimex-lpc1766stk/README.txt +++ b/configs/olimex-lpc1766stk/README.txt @@ -988,14 +988,9 @@ Configuration Sub-Directories CONFIG_LPC1766STK_USBHOST_STACKSIZE=1536 | Was 1024 STATUS: - 2015-04-26: The hub basically works. I do get crashes in the LPC16 USB host driver - when removing the keyboard from the hub. It looks like that crash - occurs consistently the 4th time that the keyboard is removed. The - crash seems seems to be due to a corrupt addess in the callback from - the new asynchronous I/O. Should not be too hard to fix. - - Also, the code does not enumerate the hub if it is connected at the - time of power up. + 2015-05-03: The hub basically works. The only problem that I see is + that the code does not enumerate the hub if it is + connected at the time of power up. hidmouse: This configuration directory supports a variant of an NSH configution. diff --git a/configs/olimex-stm32-p207/src/stm32_usb.c b/configs/olimex-stm32-p207/src/stm32_usb.c index 818359a725..c663c948ff 100644 --- a/configs/olimex-stm32-p207/src/stm32_usb.c +++ b/configs/olimex-stm32-p207/src/stm32_usb.c @@ -73,7 +73,11 @@ #endif #ifndef CONFIG_USBHOST_STACKSIZE -# define CONFIG_USBHOST_STACKSIZE 1024 +# ifdef CONFIG_USBHOST_HUB +# define CONFIG_USBHOST_STACKSIZE 1536 +# else +# define CONFIG_USBHOST_STACKSIZE 1024 +# endif #endif /************************************************************************************ diff --git a/configs/open1788/src/lpc17_nsh.c b/configs/open1788/src/lpc17_nsh.c index 9caab6fc2c..00a12aec92 100644 --- a/configs/open1788/src/lpc17_nsh.c +++ b/configs/open1788/src/lpc17_nsh.c @@ -131,7 +131,11 @@ # define CONFIG_USBHOST_DEFPRIO 50 # endif # ifndef CONFIG_USBHOST_STACKSIZE -# define CONFIG_USBHOST_STACKSIZE 1024 +# ifdef CONFIG_USBHOST_HUB +# define CONFIG_USBHOST_STACKSIZE 1536 +# else +# define CONFIG_USBHOST_STACKSIZE 1024 +# endif # endif #endif diff --git a/configs/pic32mx-starterkit/src/pic32mx_nsh.c b/configs/pic32mx-starterkit/src/pic32mx_nsh.c index 3a9ace4510..7a3813d56e 100644 --- a/configs/pic32mx-starterkit/src/pic32mx_nsh.c +++ b/configs/pic32mx-starterkit/src/pic32mx_nsh.c @@ -147,7 +147,11 @@ # define CONFIG_USBHOST_DEFPRIO 50 # endif # ifndef CONFIG_USBHOST_STACKSIZE -# define CONFIG_USBHOST_STACKSIZE 1024 +# ifdef CONFIG_USBHOST_HUB +# define CONFIG_USBHOST_STACKSIZE 1536 +# else +# define CONFIG_USBHOST_STACKSIZE 1024 +# endif # endif #endif diff --git a/configs/pic32mx7mmb/src/pic32_nsh.c b/configs/pic32mx7mmb/src/pic32_nsh.c index fefb2acbc3..f0b1e9e5b9 100644 --- a/configs/pic32mx7mmb/src/pic32_nsh.c +++ b/configs/pic32mx7mmb/src/pic32_nsh.c @@ -146,7 +146,11 @@ # define CONFIG_USBHOST_DEFPRIO 50 # endif # ifndef CONFIG_USBHOST_STACKSIZE -# define CONFIG_USBHOST_STACKSIZE 1024 +# ifdef CONFIG_USBHOST_HUB +# define CONFIG_USBHOST_STACKSIZE 1536 +# else +# define CONFIG_USBHOST_STACKSIZE 1024 +# endif # endif #endif diff --git a/configs/sama5d3x-ek/README.txt b/configs/sama5d3x-ek/README.txt index a3d77520ec..dfc2cc3638 100644 --- a/configs/sama5d3x-ek/README.txt +++ b/configs/sama5d3x-ek/README.txt @@ -1668,7 +1668,7 @@ USB High-Speed Host the nesting depth of certain USB host class logic can increase. STATUS: - Hub support has not been verified on this board. + Hub support has not been verified on this board yet. Mass Storage Device Usage ------------------------- diff --git a/configs/shenzhou/src/stm32_usb.c b/configs/shenzhou/src/stm32_usb.c index c47bbe4712..90840018d8 100644 --- a/configs/shenzhou/src/stm32_usb.c +++ b/configs/shenzhou/src/stm32_usb.c @@ -74,7 +74,11 @@ #endif #ifndef CONFIG_USBHOST_STACKSIZE -# define CONFIG_USBHOST_STACKSIZE 1024 +# ifdef CONFIG_USBHOST_HUB +# define CONFIG_USBHOST_STACKSIZE 1536 +# else +# define CONFIG_USBHOST_STACKSIZE 1024 +# endif #endif /************************************************************************************ diff --git a/configs/stm3220g-eval/src/stm32_usb.c b/configs/stm3220g-eval/src/stm32_usb.c index d1f32f9ba1..fda57cb880 100644 --- a/configs/stm3220g-eval/src/stm32_usb.c +++ b/configs/stm3220g-eval/src/stm32_usb.c @@ -74,7 +74,11 @@ #endif #ifndef CONFIG_USBHOST_STACKSIZE -# define CONFIG_USBHOST_STACKSIZE 1024 +# ifdef CONFIG_USBHOST_HUB +# define CONFIG_USBHOST_STACKSIZE 1536 +# else +# define CONFIG_USBHOST_STACKSIZE 1024 +# endif #endif /************************************************************************************ diff --git a/configs/stm3240g-eval/src/stm32_usb.c b/configs/stm3240g-eval/src/stm32_usb.c index 61e4ecb15e..a9a8be2b0f 100644 --- a/configs/stm3240g-eval/src/stm32_usb.c +++ b/configs/stm3240g-eval/src/stm32_usb.c @@ -74,7 +74,11 @@ #endif #ifndef CONFIG_USBHOST_STACKSIZE -# define CONFIG_USBHOST_STACKSIZE 1024 +# ifdef CONFIG_USBHOST_HUB +# define CONFIG_USBHOST_STACKSIZE 1536 +# else +# define CONFIG_USBHOST_STACKSIZE 1024 +# endif #endif /************************************************************************************ diff --git a/configs/sure-pic32mx/src/pic32mx_nsh.c b/configs/sure-pic32mx/src/pic32mx_nsh.c index 15ee83b445..47522a275f 100644 --- a/configs/sure-pic32mx/src/pic32mx_nsh.c +++ b/configs/sure-pic32mx/src/pic32mx_nsh.c @@ -125,7 +125,11 @@ # define CONFIG_USBHOST_DEFPRIO 50 # endif # ifndef CONFIG_USBHOST_STACKSIZE -# define CONFIG_USBHOST_STACKSIZE 1024 +# ifdef CONFIG_USBHOST_HUB +# define CONFIG_USBHOST_STACKSIZE 1536 +# else +# define CONFIG_USBHOST_STACKSIZE 1024 +# endif # endif #endif