From 6295203a82ad86a36a0d284398c3afdfd15b2a15 Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Fri, 12 Sep 2014 12:44:03 -0600 Subject: [PATCH] Cosmetic changes --- libc/unistd/lib_execv.c | 7 ++++--- tools/mksyscall.c | 6 +++++- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/libc/unistd/lib_execv.c b/libc/unistd/lib_execv.c index 64346c9db0..f4246a408d 100644 --- a/libc/unistd/lib_execv.c +++ b/libc/unistd/lib_execv.c @@ -91,9 +91,10 @@ * (2) the number of symbols in that table. This information is currently * provided to 'exec()' from 'exec[l|v]()' via NuttX configuration settings: * - * CONFIG_LIBC_EXECFUNCS : Enable exec[l|v] support - * CONFIG_EXECFUNCS_SYMTAB : Symbol table used by exec[l|v] - * CONFIG_EXECFUNCS_NSYMBOLS : Number of symbols in the table + * CONFIG_LIBC_EXECFUNCS : Enable exec[l|v] support + * CONFIG_EXECFUNCS_HAVE_SYMTAB : Defined if there is a symbol table + * CONFIG_EXECFUNCS_SYMTAB : Symbol table used by exec[l|v] + * CONFIG_EXECFUNCS_NSYMBOLS : Number of symbols in the table * * As a result of the above, the current implementations of 'execl()' and * 'execv()' suffer from some incompatibilities that may or may not be diff --git a/tools/mksyscall.c b/tools/mksyscall.c index b2616c09d9..331a16f25e 100644 --- a/tools/mksyscall.c +++ b/tools/mksyscall.c @@ -94,6 +94,7 @@ static const char *check_funcptr(const char *type) { return str + 2; } + return NULL; } @@ -104,6 +105,7 @@ static const char *check_array(const char *type) { return str; } + return NULL; } @@ -114,7 +116,8 @@ static void print_formalparm(FILE *stream, const char *argtype, int parmno) /* Function pointers and array formal parameter types are a little more work */ - if ((part2 = check_funcptr(argtype)) != NULL || (part2 = check_array(argtype)) != NULL) + if ((part2 = check_funcptr(argtype)) != NULL || + (part2 = check_array(argtype)) != NULL) { len = part2 - argtype; (void)fwrite(argtype, 1, len, stream); @@ -280,6 +283,7 @@ static void generate_proxy(int nparms) { fprintf(stream, ", "); } + print_formalparm(stream, formal, i+1); } }