sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sched/task: minor polish on task_init()

Browse Source 
This removes duplicated mask operation and revises comments.

Signed-off-by: Yanfeng Liu <yfliu2008@qq.com>
This commit is contained in:
Yanfeng Liu 2024-05-08 12:22:59 +08:00 committed by Xiang Xiao
parent ce8cfde768
commit 64e008f65b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sched/task/task_init.c
View File

@ -103,7 +103,7 @@ int nxtask_init(FAR struct task_tcb_s *tcb, const char *name, int priority,
#ifdef CONFIG_ARCH_ADDRENV #ifdef CONFIG_ARCH_ADDRENV
/* Kernel threads do not own any address environment */ /* Kernel threads do not own any address environment */
if ((ttype & TCB_FLAG_TTYPE_MASK) == TCB_FLAG_TTYPE_KERNEL) if (ttype == TCB_FLAG_TTYPE_KERNEL)
{ {
tcb->cmn.addrenv_own = NULL; tcb->cmn.addrenv_own = NULL;
} }
@ -199,7 +199,7 @@ errout_with_group:
* user memory region that will be destroyed anyway (and the * user memory region that will be destroyed anyway (and the
* address environment has probably already been destroyed at * address environment has probably already been destroyed at
* this point.. so we would crash if we even tried it). But if * this point.. so we would crash if we even tried it). But if
* this is a privileged group, when we still have to release the * this is a privileged group, then we still have to release the
* memory using the kernel allocator. * memory using the kernel allocator.
*/ */
@ -224,8 +224,8 @@ errout_with_group:
* Description: * Description:
* Undo all operations on a TCB performed by task_init() and release the * Undo all operations on a TCB performed by task_init() and release the
* TCB by calling kmm_free(). This is intended primarily to support * TCB by calling kmm_free(). This is intended primarily to support
* error recovery operations after a successful call to task_init() such * error recovery operations after a successful call to task_init()
* was when a subsequent call to task_activate fails. * when a subsequent call to task_activate fails.
* *
* Caution: Freeing of the TCB itself might be an unexpected side-effect. * Caution: Freeing of the TCB itself might be an unexpected side-effect.
* *