sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tools/nxstyle.c: Add logic to detect long lines.

Browse Source
This commit is contained in:
Gregory Nutt 2018-11-19 07:50:59 -06:00
parent 9d0740e069
commit 655904f342
1 changed files with 61 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
tools/nxstyle.c
View File

@ -37,9 +37,11 @@
* Included Files * Included Files
****************************************************************************/ ****************************************************************************/
#include <stdlib.h>
#include <stdbool.h> #include <stdbool.h>
#include <stdio.h> #include <stdio.h>
#include <string.h> #include <string.h>
#include <strings.h>
#include <ctype.h> #include <ctype.h>
/**************************************************************************** /****************************************************************************
@ -48,6 +50,16 @@
#define LINE_SIZE 512 #define LINE_SIZE 512
/****************************************************************************
* Private Functions
****************************************************************************/
static void show_usage(char *progname, int exitcode)
{
fprintf(stderr, "Usage: %s [-m <maxline>] <filename>\n", progname);
exit(exitcode);
}
/**************************************************************************** /****************************************************************************
* Public Functions * Public Functions
****************************************************************************/ ****************************************************************************/
@ -56,6 +68,7 @@ int main(int argc, char **argv, char **envp)
{ {
FILE *instream; FILE *instream;
char line[LINE_SIZE]; char line[LINE_SIZE];
char *filename;
char *lptr; char *lptr;
bool btabs; bool btabs;
bool bfunctions; bool bfunctions;
@ -78,8 +91,37 @@ int main(int argc, char **argv, char **envp)
int blank_lineno; int blank_lineno;
int noblank_lineno; int noblank_lineno;
int linelen; int linelen;
int maxline;
instream = fopen(argv[1], "r"); maxline = 78;
filename = argv[1];
/* Usage: nxstyle [-m <maxline>] <filename> */
if (argc == 4)
{
if (strcmp(argv[1], "-m") != 0)
{
fprintf(stderr, "Unrecognized argument\n");
show_usage(argv[0], 1);
}
maxline = atoi(argv[2]);
if (maxline < 1)
{
fprintf(stderr, "Bad value for <maxline>\n");
show_usage(argv[0], 1);
}
filename = argv[3];
}
else if (argc != 2)
{
fprintf(stderr, "Invalid number of arguments\n");
show_usage(argv[0], 1);
}
instream = fopen(filename, "r");
if (!instream) if (!instream)
{ {
fprintf(stderr, "Failed to open %s\n", argv[1]); fprintf(stderr, "Failed to open %s\n", argv[1]);
@ -902,14 +944,28 @@ int main(int argc, char **argv, char **envp)
} }
/* Loop terminates when NUL or newline character found */ /* Loop terminates when NUL or newline character found */
if (line[n] == '\n')
{
/* Check for space at the end of the line */ /* Check for space at the end of the line */
if (n > 1 && line[n] == '\n' && isspace((int)line[n - 1])) if (n > 1 && isspace((int)line[n - 1]))
{ {
fprintf(stderr, "Dangling whitespace at the end of line %d:%d\n", fprintf(stderr,
"Dangling whitespace at the end of line %d:%d\n",
lineno, n); lineno, n);
} }
/* Check for long lines */
if (n > maxline)
{
fprintf(stderr,
"Long line found at %d:%d\n",
lineno, n);
}
}
/* STEP 4: Check alignment */ /* STEP 4: Check alignment */
/* Within a comment block, we need only check on the alignment of the /* Within a comment block, we need only check on the alignment of the