sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

rptun_dump: do not acquire the lock when has hold the lock

Browse Source 
Otherwise, system will crash again when call rptun_dump_all()
after has acquired the lock.

Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
This commit is contained in:
Bowen Wang 2023-06-16 09:35:14 +08:00 committed by Xiang Xiao
parent 41e399aa43
commit 69756f277e
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/rptun/rptun_dump.c
View File

@ -94,13 +94,20 @@ void rptun_dump(FAR struct rpmsg_virtio_device *rvdev)
FAR struct rpmsg_device *rdev = &rvdev->rdev;
FAR struct rpmsg_endpoint *ept;
FAR struct metal_list *node;
bool needlock = true;
if (!rvdev->vdev)
{
return;
}
if (!up_interrupt_context() && !sched_idletask())
if (up_interrupt_context() || sched_idletask() ||
nxmutex_is_hold(&rdev->lock))
{
needlock = false;
}
if (needlock)
{
metal_mutex_acquire(&rdev->lock);
}
@ -128,7 +135,7 @@ void rptun_dump(FAR struct rpmsg_virtio_device *rvdev)
rptun_dump_buffer(rvdev, true);
rptun_dump_buffer(rvdev, false);
if (!up_interrupt_context() && !sched_idletask())
if (needlock)
{
metal_mutex_release(&rdev->lock);
}