sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mpfs: emmcsd: boost waitresponse perf

Browse Source 
When waiting for a response to a sent command, the command
complete bit (MPFS_EMMCSD_SRS12_CC) should always guarantee
the completion of that particular command. There's no need
to have some combinations skipping the check of the command
complete bit. Thus, remove the 'waitbits' parameter as it's
unnecessary.

Signed-off-by: Eero Nurkkala <eero.nurkkala@offcode.fi>
This commit is contained in:
Eero Nurkkala 2021-11-16 12:22:14 +02:00 committed by Xiang Xiao
parent 779a29fea5
commit 6db480a7f9
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
arch/risc-v/src/mpfs/mpfs_emmcsd.c
View File

@ -2332,7 +2332,6 @@ static int mpfs_waitresponse(struct sdio_dev_s *dev, uint32_t cmd)
struct mpfs_dev_s *priv = (struct mpfs_dev_s *)dev;
uint32_t status;
int32_t timeout;
uint32_t waitbits = 0;
mcinfo("cmd: %08" PRIx32 "\n", cmd);
@ -2363,22 +2362,17 @@ static int mpfs_waitresponse(struct sdio_dev_s *dev, uint32_t cmd)
/* Then wait for the response (or timeout) */
if (cmd & MMCSD_DATAXFR_MASK)
{
waitbits = MPFS_EMMCSD_SRS12_CC;
}
do
{
status = getreg32(MPFS_EMMCSD_SRS12);
}
while (!(status & (waitbits | MPFS_EMMCSD_SRS12_EINT))
while (!(status & (MPFS_EMMCSD_SRS12_CC | MPFS_EMMCSD_SRS12_EINT))
&& --timeout);
if (timeout == 0 || (status & MPFS_EMMCSD_SRS12_ECT))
{
mcerr("ERROR: Timeout cmd: %08" PRIx32 " stat: %08" PRIx32 " wb: %08"
PRIx32 "\n", cmd, status, waitbits);
mcerr("ERROR: Timeout cmd: %08" PRIx32 " stat: %08" PRIx32 "\n", cmd,
status);
return -EBUSY;
}