sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

arch/xmc4 : fixed critical section in i2c_transfer

Browse Source 
The critical section was declared at the wrong place.
The critical section wasn't left if error returned.
This commit is contained in:
adriendesp 2024-08-01 15:25:58 +02:00 committed by Xiang Xiao
parent f5df946676
commit 6ef8a73614
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
arch/arm/src/xmc4/xmc4_i2c.c
View File

@ -813,6 +813,10 @@ static int i2c_transfer(struct i2c_master_s *dev,
nxmutex_lock(&priv->lock);
/* Enter critical section to avoid interrupts during i2c transfert */
irqstate_t state = enter_critical_section();
for (int i = 0; i < count; i++)
{
/* Check if frequency must be changed */
@ -832,6 +836,7 @@ static int i2c_transfer(struct i2c_master_s *dev,
else
{
i2cerr("Can't update frequency between Start & Stop symbols\n");
leave_critical_section(state);
nxmutex_unlock(&priv->lock);
return -EINVAL;
}
@ -841,10 +846,6 @@ static int i2c_transfer(struct i2c_master_s *dev,
bool read = ((msgs[i].flags & I2C_M_READ) != 0);
/* Enter critical section to avoid interrupts during i2c transfert */
irqstate_t state = enter_critical_section();
/* Check if you should start or restart a new i2c frame */
if ((msgs[i].flags & I2C_M_NOSTART) == 0)