sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sched_smp:sync refcount before enqueue smp call queue

Browse Source 
Signed-off-by: dulibo1 <dulibo1@xiaomi.com>

1.call_data->refcount is not remote_cpus;
2.nxsched_smp_call_add enqueue  the call_data;
3.maybe nxsched_smp_call_handler is just doing;
4.dequeue the call_data but call_data->refcount is not corret;
5.unpredictability case will occur;
This commit is contained in:
dulibo1 2024-04-18 11:23:28 +08:00 committed by Xiang Xiao
parent a26051e7bc
commit 6fd1ca64a1
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sched/sched/sched_smp.c
View File

@ -239,7 +239,8 @@ int nxsched_smp_call(cpu_set_t cpuset, nxsched_smp_call_t func,
CPU_CLR(this_cpu(), &cpuset); CPU_CLR(this_cpu(), &cpuset);
} }
if (CPU_COUNT(&cpuset) == 0) remote_cpus = CPU_COUNT(&cpuset);
if (remote_cpus == 0)
{ {
goto out; goto out;
} }
@ -261,22 +262,17 @@ int nxsched_smp_call(cpu_set_t cpuset, nxsched_smp_call_t func,
call_data->func = func; call_data->func = func;
call_data->arg = arg; call_data->arg = arg;
call_data->refcount = remote_cpus;
for (i = 0; i < CONFIG_SMP_NCPUS; i++) for (i = 0; i < CONFIG_SMP_NCPUS; i++)
{ {
if (CPU_ISSET(i, &cpuset)) if (CPU_ISSET(i, &cpuset))
{ {
nxsched_smp_call_add(i, call_data); nxsched_smp_call_add(i, call_data);
remote_cpus++;
} }
} }
call_data->refcount = remote_cpus; up_send_smp_call(cpuset);
if (remote_cpus > 0)
{
up_send_smp_call(cpuset);
}
if (wait) if (wait)
{ {