sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

filemtd:Fix teardown return error number EINVAL

Browse Source 
In previous versions, during the teardown phase, the "open_blockdriver" would call the "mtd proxy" causing the "file mtd" node to be registered in the ftl. " node is registered in ftl.
Therefore, we changed the behavior to find the corresponding inode by node name.

Signed-off-by: chenrun1 <chenrun1@xiaomi.com>
This commit is contained in:
chenrun1 2023-10-07 14:02:14 +08:00 committed by Xiang Xiao
parent 095c32b0eb
commit 73ca090ab9
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/mtd/filemtd.c
View File

@ -569,14 +569,12 @@ static int mtd_loop_teardown(FAR const char *devname)
FAR struct inode *inode; FAR struct inode *inode;
int ret; int ret;
/* Open the block driver associated with devname so that we can get the /* Find the reference to the inode by devname */
* inode reference.
*/
ret = open_blockdriver(devname, MS_RDONLY, &inode); ret = find_mtddriver(devname, &inode);
if (ret < 0) if (ret < 0)
{ {
ferr("ERROR: Failed to open %s: %d\n", devname, -ret); ferr("ERROR: Failed to find %s: %d\n", devname, -ret);
return ret; return ret;
} }
@ -589,16 +587,16 @@ static int mtd_loop_teardown(FAR const char *devname)
if (!filemtd_isfilemtd(&dev->mtd)) if (!filemtd_isfilemtd(&dev->mtd))
{ {
ferr("ERROR: Device is not a FILEMTD loop: %s\n", devname); ferr("ERROR: Device is not a FILEMTD loop: %s\n", devname);
close_mtddriver(inode);
return -EINVAL; return -EINVAL;
} }
close_blockdriver(inode); close_mtddriver(inode);
/* Now teardown the filemtd */ /* Now teardown the filemtd */
filemtd_teardown(&dev->mtd); filemtd_teardown(&dev->mtd);
unregister_blockdriver(devname); unregister_mtddriver(devname);
kmm_free(dev);
return OK; return OK;
} }