sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add comments; note potential bug

Browse Source 
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@1215 42af7a65-404d-4744-a932-0658087f49c3
This commit is contained in:
patacongo 2008-11-13 01:02:56 +00:00
parent faa3ce6b97
commit 7c60be1954
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/serialirq.c
View File

@ -129,16 +129,30 @@ void uart_recvchars(FAR uart_dev_t *dev)
nexthead = 0;
}
/* Loop putting characters into the receive buffer until eithe: (1) the buffer
* is full, or (2) there are not further characters to add.
*/
while (nexthead != dev->recv.tail && uart_rxavailable(dev))
{
/* Add the character to the buffer */
dev->recv.buffer[dev->recv.head] = uart_receive(dev, &status);
/* Increment the index */
dev->recv.head = nexthead;
if (++nexthead >= dev->recv.size)
{
nexthead = 0;
}
/* A character was added... if there is a thread waiting for more data, then
* post the recvsem semaphore to wake it up. NOTE: There is a logic error in
* the above looping logic: If nexthead == dev->recv.tail on entry and
* recvwaiting is true, the recvsem will never get posted!
*/
if (dev->recvwaiting)
{
dev->recvwaiting = FALSE;