sergiotarxz/nuttx
sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

noteram: when the buffer overflow happen and give the asan report

Browse Source 
READ of size 1 at 0x5ec78f90 thread T0
0 0x59682d7a in noteram_remove note/noteram_driver.c:432
1 0x59683c43 in sched_note_add note/noteram_driver.c:854
0x5ec78f90 is located 0 bytes to the right of global variable 'g_noteram_info' defined in 'note/noteram_driver.c:95:30' (0x5ec78780) of size 2064
0x5ec78f90 is located 48 bytes to the left of global variable '*.Lubsan_type0' defined in 'note/noteram_driver.c' (0x5ec78fc0) of size 10
reason: that read pos is tail of g_noteram_info.ni_buffer causes overflow
This commit is contained in:
zhanghu6 2021-12-06 11:02:32 +08:00 committed by Xiang Xiao
parent a35d205f3b
commit 84019b9170
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/note/noteram_driver.c
View File

@ -412,7 +412,6 @@ static unsigned int noteram_unread_length(void)
static void noteram_remove(void) static void noteram_remove(void)
{ {
FAR struct note_common_s *note;
unsigned int tail; unsigned int tail;
unsigned int length; unsigned int length;
@ -423,18 +422,27 @@ static void noteram_remove(void)
/* Get the length of the note at the tail index */ /* Get the length of the note at the tail index */
note = (FAR struct note_common_s *)&g_noteram_info.ni_buffer[tail]; length = g_noteram_info.ni_buffer[tail];
length = note->nc_length;
DEBUGASSERT(length <= noteram_length()); DEBUGASSERT(length <= noteram_length());
#if CONFIG_DRIVER_NOTERAM_TASKNAME_BUFSIZE > 0 #if CONFIG_DRIVER_NOTERAM_TASKNAME_BUFSIZE > 0
if (note->nc_type == NOTE_STOP) if (g_noteram_info.ni_buffer[noteram_next(tail, 1)] == NOTE_STOP)
{ {
uint8_t nc_pid[2];
/* The name of the task is no longer needed because the task is deleted /* The name of the task is no longer needed because the task is deleted
* and the corresponding notes are lost. * and the corresponding notes are lost.
*/ */
noteram_remove_taskname(note->nc_pid[0] + (note->nc_pid[1] << 8)); #ifdef CONFIG_SMP
nc_pid[0] = g_noteram_info.ni_buffer[noteram_next(tail, 4)];
nc_pid[1] = g_noteram_info.ni_buffer[noteram_next(tail, 5)];
#else
nc_pid[0] = g_noteram_info.ni_buffer[noteram_next(tail, 3)];
nc_pid[1] = g_noteram_info.ni_buffer[noteram_next(tail, 4)];
#endif
noteram_remove_taskname(nc_pid[0] + (nc_pid[1] << 8));
} }
#endif #endif