CAN driver: Improve some comments

This commit is contained in:
Gregory Nutt 2015-11-08 07:00:09 -06:00
parent 91429433f6
commit 874862abb9
2 changed files with 12 additions and 3 deletions

2
arch

@ -1 +1 @@
Subproject commit 2137b6c754118003664432d16dd4b69685939c74
Subproject commit c3b18f485b208adcc005f39d50c202e4ae795e91

View File

@ -1109,18 +1109,27 @@ int can_txready(FAR struct can_dev_s *dev)
if (dev->cd_ntxwaiters > 0)
{
/* Verify that the xmit FIFO is not empty.
*
* REVISIT: This probably should be an assertion since we should only
* be waiting for space in the xmit FIFO if the xmit FIFO is full.
*/
if (dev->cd_xmit.tx_head != dev->cd_xmit.tx_tail)
{
/* Send the next message in the FIFO, making space in the xmit FIFO */
/* Send the next message in the S/W FIFO. In the case where the
* H/W TX FIFO is not empty, this should add one more CAN message
* to the H/W TX FIFO and can_txdone() should be called, making
* space in the S/W FIFO
*/
(void)can_xmit(dev);
}
/* Inform one waiter that new xmit space is available */
/* Inform one waiter that new xmit space is available in the S/W FIFO.
* NOTE that is can_txdone() is, indeed, called twice that the tx_sem
* will also be posted twice. This is a little inefficient, but not
* harmful.
*/
ret = sem_post(&dev->cd_xmit.tx_sem);
}