From 8a80a853b77c649fc7bfe6754c12b75815023a45 Mon Sep 17 00:00:00 2001 From: Jiuzhu Dong Date: Fri, 1 Apr 2022 11:03:56 +0800 Subject: [PATCH] fs/romfs: fix string overflow when the length of rn_name exceeds NAME_MAX + 1 Signed-off-by: Jiuzhu Dong --- fs/romfs/fs_romfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/romfs/fs_romfs.c b/fs/romfs/fs_romfs.c index 80d4c4210a..ea773ed004 100644 --- a/fs/romfs/fs_romfs.c +++ b/fs/romfs/fs_romfs.c @@ -870,7 +870,8 @@ static int romfs_readdir(FAR struct inode *mountpt, #ifdef CONFIG_FS_ROMFS_CACHE_NODE next = (*dir->u.romfs.fr_currnode)->rn_next; - strcpy(dir->fd_dir.d_name, (*dir->u.romfs.fr_currnode)->rn_name); + strlcpy(dir->fd_dir.d_name, (*dir->u.romfs.fr_currnode)->rn_name, + sizeof(dir->fd_dir.d_name)); dir->u.romfs.fr_currnode++; #else /* Parse the directory entry */