diff --git a/configs/sabre-6quad/README.txt b/configs/sabre-6quad/README.txt index 84571090f7..6c492857b2 100644 --- a/configs/sabre-6quad/README.txt +++ b/configs/sabre-6quad/README.txt @@ -56,11 +56,11 @@ With this change, the NSH serial console works: But there are still no timer interrupts. LEDs do not appear to be working. 2016-05-17: Timer interrupts now work. This turned out to be just a minor -bit setting error in the timer configuration. Timer appears to be too fast -be about a factor of three, however. +bit setting error in the timer configuration. LEDs were not working simply +because board_autoled_initialize() was not being called in the board startup +logic. -LEDs were not working simply because board_autoled_initialize() was not being -called in the board startup logic. +At this point, I would say that the basic NSH port is complete. Platform Features ================= @@ -129,7 +129,7 @@ LEDs ---- A single LED is available driven GPIO1_IO02. On the schematic this is USR_DEF_RED_LED signal to pin T1 (GPIO_2). This signal is shared with -KEY_ROW6 (ALT2). A low value illuminates the LED. +KEY_ROW6 (ALT2). A high value illuminates the LED. This LED is not used by the board port unless CONFIG_ARCH_LEDS is defined. In that case, the usage by the board port is defined in diff --git a/configs/sabre-6quad/include/board.h b/configs/sabre-6quad/include/board.h index f9d7d8e95b..e6d4dd4ade 100644 --- a/configs/sabre-6quad/include/board.h +++ b/configs/sabre-6quad/include/board.h @@ -88,7 +88,7 @@ * * A single LED is available driven GPIO1_IO02. On the schematic this is * USR_DEF_RED_LED signal to pin T1 (GPIO_2). This signal is shared with KEY_ROW6 - * (ALT2). A low value illuminates the LED. + * (ALT2). A high value illuminates the LED. */ /* LED index values for use with board_userled() */ diff --git a/configs/sabre-6quad/src/imx_autoleds.c b/configs/sabre-6quad/src/imx_autoleds.c index ce31d0a93e..10a3a556d9 100644 --- a/configs/sabre-6quad/src/imx_autoleds.c +++ b/configs/sabre-6quad/src/imx_autoleds.c @@ -117,7 +117,7 @@ void board_autoled_on(int led) { if (led == 1 || led == 3) { - imx_gpio_write(GPIO_LED, false); /* Low illuminates */ + imx_gpio_write(GPIO_LED, true); /* High illuminates */ } } @@ -129,7 +129,7 @@ void board_autoled_off(int led) { if (led == 3) { - imx_gpio_write(GPIO_LED, true); /* High extinguishes */ + imx_gpio_write(GPIO_LED, false); /* Low extinguishes */ } } diff --git a/configs/sabre-6quad/src/sabre-6quad.h b/configs/sabre-6quad/src/sabre-6quad.h index 5ae480d637..b70589dbe3 100644 --- a/configs/sabre-6quad/src/sabre-6quad.h +++ b/configs/sabre-6quad/src/sabre-6quad.h @@ -57,12 +57,12 @@ * * A single LED is available driven GPIO1_IO02. On the schematic this is * USR_DEF_RED_LED signal to pin T1 (GPIO_2). This signal is shared with KEY_ROW6 - * (ALT2). A low value illuminates the LED. + * (ALT2). A high value illuminates the LED. */ #define IOMUX_LED (IOMUX_PULL_NONE | IOMUX_CMOS_OUTPUT | IOMUX_DRIVE_40OHM | \ IOMUX_SPEED_MEDIUM | IOMUX_SLEW_SLOW) -#define GPIO_LED (GPIO_OUTPUT | GPIO_OUTPUT_ONE | GPIO_PORT1 | GPIO_PIN2 | \ +#define GPIO_LED (GPIO_OUTPUT | GPIO_OUTPUT_ZERO | GPIO_PORT1 | GPIO_PIN2 | \ IOMUX_LED) /************************************************************************************