sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add a debug assertion for logic error in previous commit

Browse Source
This commit is contained in:
Gregory Nutt 2016-03-04 10:28:13 -06:00
parent a115e13e06
commit 910e649616
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
arch/arm/src/samv7/sam_mcan.c
View File

@ -1558,6 +1558,17 @@ static void mcan_buffer_reserve(FAR struct sam_mcan_s *priv)
if (sval != tffl) if (sval != tffl)
{ {
candbg("ERROR: TX FIFO reports %d but txfsem is %d\n", tffl, sval); candbg("ERROR: TX FIFO reports %d but txfsem is %d\n", tffl, sval);
/* REVISIT: The following is dangerous and non-standard usage of the
* semaphore count. It can only work if the count is non-negative.
* If the count because negative, then forcing it to a non-negative
* value will cause the system to hang.
*
* A proper solution might be a loop that calls sem_post() or sem_wait()
* repeteadly to adjust the count.
*/
DEBUGASSERT(priv->txfsem.count >= 0);
sem_init(&priv->txfsem, 0, tffl); sem_init(&priv->txfsem, 0, tffl);
} }
#endif #endif