sergiotarxz/nuttx
sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

usrsock: Add DebugAssert for poll setup result

Browse Source 
We never check its result and assume it will success, so an assert should be better than retval.

Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
This commit is contained in:
Zhe Weng 2023-02-17 14:58:18 +08:00 committed by Xiang Xiao
parent be0cb4cbe3
commit 9d53de374c
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/usrsock/usrsock_rpmsg_server.c
View File

@ -129,7 +129,7 @@ static int usrsock_rpmsg_ept_cb(FAR struct rpmsg_endpoint *ept,
FAR void *priv); FAR void *priv);
static void usrsock_rpmsg_poll_cb(FAR struct pollfd *pfds); static void usrsock_rpmsg_poll_cb(FAR struct pollfd *pfds);
static int usrsock_rpmsg_poll_setup(FAR struct pollfd *pfds, static void usrsock_rpmsg_poll_setup(FAR struct pollfd *pfds,
pollevent_t events); pollevent_t events);
/**************************************************************************** /****************************************************************************
@ -1021,7 +1021,7 @@ static int usrsock_rpmsg_ept_cb(FAR struct rpmsg_endpoint *ept,
return -EINVAL; return -EINVAL;
} }
static int usrsock_rpmsg_poll_setup(FAR struct pollfd *pfds, static void usrsock_rpmsg_poll_setup(FAR struct pollfd *pfds,
pollevent_t events) pollevent_t events)
{ {
FAR struct usrsock_rpmsg_s *priv = (FAR struct usrsock_rpmsg_s *)pfds->arg; FAR struct usrsock_rpmsg_s *priv = (FAR struct usrsock_rpmsg_s *)pfds->arg;
@ -1050,7 +1050,7 @@ static int usrsock_rpmsg_poll_setup(FAR struct pollfd *pfds,
net_unlock(); net_unlock();
return ret; DEBUGASSERT(ret >= 0);
} }
static void usrsock_rpmsg_poll_cb(FAR struct pollfd *pfds) static void usrsock_rpmsg_poll_cb(FAR struct pollfd *pfds)