From 9de449c8b6e79c51d7cca74a8c1da3b7310d1797 Mon Sep 17 00:00:00 2001 From: Huang Qi Date: Fri, 28 Apr 2023 15:15:19 +0800 Subject: [PATCH] drivers/telnet: Refused to enter character mode Refuse SGA to work in line mode, it's OK for modern rich featured telnet clients. Signed-off-by: Huang Qi --- drivers/net/telnet.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/telnet.c b/drivers/net/telnet.c index 6b3633015e..5d7bac4eeb 100644 --- a/drivers/net/telnet.c +++ b/drivers/net/telnet.c @@ -416,7 +416,16 @@ static ssize_t telnet_receive(FAR struct telnet_dev_s *priv, case STATE_DO: - if ((priv->td_lflag & ECHO) != 0 && ch == TELNET_ECHO) + if (ch == TELNET_SGA) + { + /* Reply with a WONT, that means we will not work in + * character mode and stay in line mode, + * it's OK for modern rich featured telnet clients. + */ + + telnet_sendopt(priv, TELNET_WONT, ch); + } + else if ((priv->td_lflag & ECHO) != 0 && ch == TELNET_ECHO) { telnet_sendopt(priv, TELNET_WONT, ch); }