sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

net/icmpv6: Fix datalen in icmpv6_reply

Browse Source 
The `datalen` indicates the whole len of original packet, which will become the payload inside icmpv6 packet.

Using `datalen = (ipv4->len[0] << 8) + ipv4->len[1]` in icmp_reply is correct, because it includes IPv4 header, but when coming to IPv6, the `len` does not include the header, so we need to add it back.

Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
This commit is contained in:
Zhe Weng 2022-11-24 16:59:31 +08:00 committed by Xiang Xiao
parent 233974b327
commit a26ea96f3b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/icmpv6/icmpv6_reply.c
View File

@ -99,9 +99,9 @@ void icmpv6_reply(FAR struct net_driver_s *dev, int type, int code, int data)
return; return;
} }
/* Get the data size of the packet. */ /* Get the data (whole original packet) size of the packet. */
datalen = (ipv6->len[0] << 8) + ipv6->len[1]; datalen = (ipv6->len[0] << 8) + ipv6->len[1] + IPv6_HDRLEN;
/* RFC says return as much as we can without exceeding 1280 bytes. */ /* RFC says return as much as we can without exceeding 1280 bytes. */