sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sched: Remove the unused tcb argument from group_setupidlefiles

Browse Source 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
This commit is contained in:
Xiang Xiao 2023-10-15 14:27:39 +08:00 committed by Petro Karashchenko
parent 0e75e53cc8
commit a34be7f7c2
3 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sched/group/group.h
View File

@ -119,7 +119,7 @@ void group_remove_children(FAR struct task_group_s *group);
/* Group data resource configuration */
int group_setupidlefiles(FAR struct task_tcb_s *tcb);
int group_setupidlefiles(void);
int group_setuptaskfiles(FAR struct task_tcb_s *tcb);
#endif /* __SCHED_GROUP_GROUP_H */

13
sched/group/group_setupidlefiles.c
View File

@ -49,7 +49,7 @@
* Configure the idle thread's TCB.
*
* Input Parameters:
* tcb - tcb of the idle task.
* None.
*
* Returned Value:
* 0 is returned on success; a negated errno value is returned on a
@ -57,7 +57,7 @@
*
****************************************************************************/
int group_setupidlefiles(FAR struct task_tcb_s *tcb)
int group_setupidlefiles(void)
{
int ret = OK;
#if defined(CONFIG_DEV_CONSOLE) || defined(CONFIG_DEV_NULL)
@ -65,7 +65,6 @@ int group_setupidlefiles(FAR struct task_tcb_s *tcb)
#endif
sched_trace_begin();
DEBUGASSERT(tcb->cmn.group != NULL);
/* Open stdin, dup to get stdout and stderr. This should always
* be the first file opened and, hence, should always get file
@ -73,11 +72,11 @@ int group_setupidlefiles(FAR struct task_tcb_s *tcb)
*/
#if defined(CONFIG_DEV_CONSOLE) || defined(CONFIG_DEV_NULL)
#ifdef CONFIG_DEV_CONSOLE
# ifdef CONFIG_DEV_CONSOLE
fd = nx_open("/dev/console", O_RDWR);
#else
# else
fd = nx_open("/dev/null", O_RDWR);
#endif
# endif
if (fd == 0)
{
/* Successfully opened stdin (fd == 0) */
@ -112,7 +111,7 @@ int group_setupidlefiles(FAR struct task_tcb_s *tcb)
* It's a common practice to keep 0-2 always open even if they are
* /dev/null to avoid that kind of problems. Thus the following warning.
*/
#warning file descriptors 0-2 are not opened
# warning file descriptors 0-2 are not opened
#endif /* defined(CONFIG_DEV_CONSOLE) || defined(CONFIG_DEV_NULL) */
sched_trace_end();

2
sched/init/nx_start.c
View File

@ -661,7 +661,7 @@ void nx_start(void)
* IDLE task.
*/
DEBUGVERIFY(group_setupidlefiles(&g_idletcb[i]));
DEBUGVERIFY(group_setupidlefiles());
}
}