sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

More patches/bugfixes from Kate

Browse Source 
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@5056 42af7a65-404d-4744-a932-0658087f49c3
This commit is contained in:
patacongo 2012-08-26 23:29:37 +00:00
parent 921acc38cc
commit a6adaff343
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
arch/arm/src/lpc17xx/lpc17_ethernet.c
View File

@ -2100,9 +2100,29 @@ static inline int lpc17_phyinit(struct lpc17_driver_s *priv)
/* Disable auto-configuration. Set the fixed speed/duplex mode.
* (probably more than little redundant).
*
* REVISIT: Revisit the following CONFIG_PHY_CEMENT_DISABLE work-around:
*
* "... I found this using a LPC1768 dev board with a DP83848I PHY. I'm
* using CONFIG_PHY_DP83848C for that ... I found that a static
* configuration for the PHY gave errors. I didn't investigate why.
*
* "My problem however was that autonegotiation seemingly failed -
* however on debugging I saw the calls for autonegotation were actually
* successful. I tracked the code down to [the following logic] and
* I saw that after the negotation completes, those negotiated
* parameters are then used to set a fixed speed and duplex, "just
* in case". It was that setting of a static configuration which
* failed for me."
*
* "I'm not sure if that's required for other situations or not, so I
* added a #define to optionally elide the call to cement the
* configuration. My PHY appears to be happy with this for the moment."
*/
#ifndef CONFIG_PHY_CEMENT_DISABLE
ret = lpc17_phymode(phyaddr, priv->lp_mode);
#endif
lpc17_showmii(phyaddr, "After final configuration");
return ret;
}