sergiotarxz/nuttx
sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drivers/note: Remove the warning of preemption and critical sections

Browse Source 
since both aren't suitable after:
commit 98ab55ef6858170bccd151c56a7fd28a0a28860b
Author: Xiang Xiao <xiaoxiang@xiaomi.com>
Date:   Fri Dec 30 12:02:47 2022 +0800

    drivers/note: Replace the scritical section with spin_xxx_wo_note

    to avoid to generate the unexpected schedule information

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
This commit is contained in:
Xiang Xiao 2023-02-20 17:40:20 +08:00 committed by archer
parent e29d275ef8
commit a841be9b9c
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/note/notelog_driver.c
View File

@ -308,13 +308,6 @@ static void notelog_cpu_resumed(FAR struct note_driver_s *drv,
#endif #endif
#ifdef CONFIG_SCHED_INSTRUMENTATION_PREEMPTION #ifdef CONFIG_SCHED_INSTRUMENTATION_PREEMPTION
/* This does not work well... it interferes with the operation of the
* simulated /dev/console device which, of course, does disable preemption
* and does use critical sections.
*/
#warning CONFIG_SCHED_INSTRUMENTATION_PREEMPTION is a bad idea
static void notelog_premption(FAR struct note_driver_s *drv, static void notelog_premption(FAR struct note_driver_s *drv,
FAR struct tcb_s *tcb, bool locked) FAR struct tcb_s *tcb, bool locked)
{ {
@ -339,13 +332,6 @@ static void notelog_premption(FAR struct note_driver_s *drv,
#endif #endif
#ifdef CONFIG_SCHED_INSTRUMENTATION_CSECTION #ifdef CONFIG_SCHED_INSTRUMENTATION_CSECTION
/* This does not work well... it interferes with the operation of the
* simulated /dev/console device which, of course, does disable preemption
* and does use critical sections.
*/
#warning CONFIG_SCHED_INSTRUMENTATION_CSECTION is a bad idea
static void notelog_csection(FAR struct note_driver_s *drv, static void notelog_csection(FAR struct note_driver_s *drv,
FAR struct tcb_s *tcb, bool enter) FAR struct tcb_s *tcb, bool enter)
{ {