sergiotarxz/nuttx
sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tcp_netpoll.c: Fix a performance issue with CONFIG_NET_TCP_WRITE_BUFFERS

Browse Source 
Tested with a modified version of webclient, which uses non-blocking i/o.
The packet dumps look more reasonable with this change.
This commit is contained in:
YAMAMOTO Takashi 2021-04-05 16:21:17 +09:00 committed by Xiang Xiao
parent 0fc329d814
commit acc3596adc
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
net/tcp/tcp_netpoll.c
View File

@ -97,7 +97,18 @@ static uint16_t tcp_poll_eventhandler(FAR struct net_driver_s *dev,
/* A poll is a sign that we are free to send data. */ /* A poll is a sign that we are free to send data. */
else if (psock_tcp_cansend(info->psock) >= 0) /* Wake up poll() speculatively on TCP_ACKDATA.
* Note: our event handler is usually executed before
* psock_send_eventhandler, which might free IOBs/WRBs on TCP_ACKDATA.
* Revisit: consider some kind of priority for devif callback to allow
* this callback to be inserted after psock_send_eventhandler.
*/
else if (psock_tcp_cansend(info->psock) >= 0
#if defined(CONFIG_NET_TCP_WRITE_BUFFERS)
|| (flags & TCP_ACKDATA) != 0
#endif
)
{ {
eventset |= (POLLOUT & info->fds->events); eventset |= (POLLOUT & info->fds->events);
} }
@ -198,7 +209,11 @@ int tcp_pollsetup(FAR struct socket *psock, FAR struct pollfd *fds)
if ((fds->events & POLLOUT) != 0) if ((fds->events & POLLOUT) != 0)
{ {
cb->flags |= TCP_POLL; cb->flags |= TCP_POLL
#if defined(CONFIG_NET_TCP_WRITE_BUFFERS)
| TCP_ACKDATA
#endif
;
} }
if ((fds->events & POLLIN) != 0) if ((fds->events & POLLIN) != 0)