sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

net/tcp: Reply RST when we cannot receive data

Browse Source 
According to RFC 2525, Section 2.17:
"When an application closes a connection in such a way that it can no longer read any received data, the TCP SHOULD, per section 4.2.2.13 of RFC 1122, send a RST if there is any unread received data, or if any new data is received."

When our TCP socket is closed (even when the thread has exited), the peer can keep sending data and NuttX keeps replying ACK (we've tried for ~12h). This is not a good behavior (also different from Linux), so send RST instead of ACK for data receiving in FIN_WAIT.

Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
This commit is contained in:
Zhe Weng 2023-03-27 17:52:19 +08:00 committed by Alan Carvalho de Assis
parent 9fd4d6b767
commit b058f37353
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
net/tcp/tcp_input.c
View File

@ -1545,7 +1545,15 @@ found:
if (dev->d_len > 0) if (dev->d_len > 0)
{ {
tcp_send(dev, conn, TCP_ACK, tcpiplen); /* Due to RFC 2525, Section 2.17, we SHOULD send RST if we can no
* longer read any received data. Also set state into TCP_CLOSED
* because the peer will not send FIN after RST received.
*
* TODO: Modify shutdown behavior to allow read in FIN_WAIT.
*/
conn->tcpstateflags = TCP_CLOSED;
tcp_reset(dev, conn);
return; return;
} }
@ -1572,7 +1580,13 @@ found:
if (dev->d_len > 0) if (dev->d_len > 0)
{ {
tcp_send(dev, conn, TCP_ACK, tcpiplen); /* Due to RFC 2525, Section 2.17, we SHOULD send RST if we can no
* longer read any received data. Also set state into TCP_CLOSED
* because the peer will not send FIN after RST received.
*/
conn->tcpstateflags = TCP_CLOSED;
tcp_reset(dev, conn);
return; return;
} }