sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

risc-v/mpfs: opensbi: fix random boot failures

Browse Source 
After the commit b8b541f, the system would not start up properly
with certain coldboot conditions. For example, if the OpenSBI picked
hart4 as the coldboot hart in preference to hart3, the system would
get stuck due to stack corruption. OpenSBI uses a lottery mechanism
to pick the coldboot hart.

Also fix g_scratches area in such a manner than it will not get
initialized to zero. If several harts initialize the area to zero, there's
danger the stack pointer gets wiped out.

Now any coldboot hart works.

Signed-off-by: Eero Nurkkala <eero.nurkkala@offcode.fi>
This commit is contained in:
Eero Nurkkala 2022-11-04 15:56:45 +02:00 committed by Xiang Xiao
parent e791d73bb2
commit b7d2b38700
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/risc-v/src/mpfs/mpfs_opensbi.c
View File

@ -225,7 +225,7 @@ static const struct sbi_platform platform =
/* This must go into l2_scratchpad region, starting at 0x0a000000. */
sbi_scratch_holder_t g_scratches[MPFS_MAX_NUM_HARTS] \
sbi_scratch_holder_t g_scratches[0] \
__attribute__((section(".l2_scratchpad")));
/****************************************************************************

1
arch/risc-v/src/mpfs/mpfs_opensbi_utils.S
View File

@ -103,7 +103,6 @@ mpfs_opensbi_prepare_hart:
mul t0, a0, t1
la sp, g_scratches
add sp, sp, t0
add sp, sp, t1
jal mpfs_opensbi_setup
/****************************************************************************