sergiotarxz/nuttx
sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

arm: sama5: sam_ehci: fix transfer cancellation process.

Browse Source 
The logic of the conditional expression that determines whether
the QH is a target QH or not is reversed in the process of canceling
a transfer in INPROGRESS state.

Therefore, the QH in INPROGRESS state is not released and subsequent
communication is not successful.

Checked with CDC-ACM driver and cu command.

Signed-off-by: Takeyoshi Kikuchi <kikuchi@centurysys.co.jp>
This commit is contained in:
Takeyoshi Kikuchi 2024-01-20 13:28:16 +09:00 committed by Xiang Xiao
parent 2ab9a848a0
commit bca8df7d65
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arch/arm/src/sama5/sam_ehci.c
View File

@ -2719,7 +2719,7 @@ static int sam_qh_cancel(struct sam_qh_s *qh, uint32_t **bp, void *arg)
/* Check if this is the QH that we are looking for */
if (qh->epinfo == epinfo)
if (qh->epinfo != epinfo)
{
/* No... keep looking */
@ -4441,7 +4441,7 @@ static int sam_cancel(struct usbhost_driver_s *drvr, usbhost_ep_t ep)
* head.
*/
if (qh && qh != &g_asynchead)
if (qh && qh == &g_asynchead)
{
/* Claim that we successfully cancelled the transfer */