sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drivers/video: Fix bug that is_available() is false

Browse Source 
is_available() may be false because chip id register does not
have unique value.
So, judge availability not by chip id but by i2c accessibility.
This commit is contained in:
SPRESENSE 2021-12-10 03:25:22 +09:00 committed by Petro Karashchenko
parent b296494fb8
commit bea6d3a7ef
2 changed files with 8 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
drivers/video/isx012.c
View File

@ -1241,39 +1241,18 @@ int init_isx012(FAR struct isx012_dev_s *priv)
return ret; return ret;
} }
static void get_chipid(uint32_t *l, uint32_t *h)
{
uint16_t l1;
uint16_t l2;
uint16_t h1;
uint16_t h2;
ASSERT(l && h);
l1 = isx012_getreg(&g_isx012_private, OTP_CHIPID_L, 2);
l2 = isx012_getreg(&g_isx012_private, OTP_CHIPID_L + 2, 2);
h1 = isx012_getreg(&g_isx012_private, OTP_CHIPID_H, 2);
h2 = isx012_getreg(&g_isx012_private, OTP_CHIPID_H + 2, 2);
*l = (l2 << 16) | l1;
*h = (h2 << 16) | h1;
}
static bool isx012_is_available(void) static bool isx012_is_available(void)
{ {
bool ret = false; bool ret;
uint32_t l;
uint32_t h;
isx012_init(); isx012_init();
get_chipid(&l, &h); /* Try to access via I2C.
* Select DEVICESTS register, which has positive value.
*/
ret = (isx012_getreg(&g_isx012_private, DEVICESTS, 1) == DEVICESTS_SLEEP);
if ((l == ISX012_CHIPID_L) && (h == ISX012_CHIPID_H))
{
ret = true;
}
isx012_uninit(); isx012_uninit();

2
drivers/video/isx012_reg.h
View File

@ -1401,4 +1401,6 @@
#define REGVAL_INTCLR0_ALLCLEAR (0x3F) #define REGVAL_INTCLR0_ALLCLEAR (0x3F)
#define DEVICESTS_SLEEP (2)
#endif /* __INCLUDE_NUTTX_VIDEO_ISX012_REG_H */ #endif /* __INCLUDE_NUTTX_VIDEO_ISX012_REG_H */