sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

arch: lc823450: Replace the critical section with spinlock in lc823450_serial.c

Browse Source 
Summary:
- This commit replaces the critical section with spinlock
- The logic is the same as cxd56_serial.c

Impact:
- None

Testing:
- Tested with lc823450-xgevk:bt

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
This commit is contained in:
Masayuki Ishikawa 2021-12-08 08:14:30 +09:00 committed by Xiang Xiao
parent 3d4be7089c
commit bec9058b4c
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
arch/arm/src/lc823450/lc823450_serial.c
View File

@ -40,6 +40,7 @@
#include <nuttx/fs/ioctl.h>
#include <nuttx/semaphore.h>
#include <nuttx/serial/serial.h>
#include <nuttx/spinlock.h>
#include <arch/board/board.h>
@ -172,6 +173,7 @@ struct up_dev_s
sem_t rxpkt_wait;
sem_t txdma_wait;
#endif /* CONFIG_HSUART */
spinlock_t lock;
};
/****************************************************************************
@ -944,7 +946,7 @@ static void up_txint(struct uart_dev_s *dev, bool enable)
struct up_dev_s *priv = (struct up_dev_s *)dev->priv;
irqstate_t flags;
flags = enter_critical_section();
flags = spin_lock_irqsave(&priv->lock);
if (enable)
{
/* Set to receive an interrupt when the TX fifo is half emptied */
@ -963,7 +965,9 @@ static void up_txint(struct uart_dev_s *dev, bool enable)
* the TX interrupt.
*/
spin_unlock_irqrestore(&priv->lock, flags);
uart_xmitchars(dev);
flags = spin_lock_irqsave(&priv->lock);
#endif
}
else
@ -974,7 +978,7 @@ static void up_txint(struct uart_dev_s *dev, bool enable)
up_serialout(priv, UART_UIEN, priv->im);
}
leave_critical_section(flags);
spin_unlock_irqrestore(&priv->lock, flags);
}
/****************************************************************************