arch/arm/src/stm32h7/stm32_pwm: nxstyle fixes

This commit is contained in:
raiden00pl 2020-04-21 17:27:11 +02:00 committed by Xiang Xiao
parent d89b9102cc
commit c2162365fc
2 changed files with 41 additions and 31 deletions

View File

@ -1694,7 +1694,6 @@ static void pwm_putreg(struct stm32_pwmtimer_s *priv, int offset,
static void pwm_modifyreg(struct stm32_pwmtimer_s *priv, uint32_t offset,
uint32_t clearbits, uint32_t setbits)
{
if (pwm_reg_is_32bit(priv->timtype, offset) == true)
{
/* 32-bit register */
@ -1753,7 +1752,7 @@ static void pwm_dumpregs(struct stm32_pwmtimer_s *priv, FAR const char *msg)
pwm_getreg(priv, STM32_GTIM_EGR_OFFSET),
pwm_getreg(priv, STM32_GTIM_CCMR1_OFFSET));
}
else
else
{
pwminfo(" SR: %04x EGR: %04x CCMR1: %04x CCMR2: %04x\n",
pwm_getreg(priv, STM32_GTIM_SR_OFFSET),
@ -1822,7 +1821,6 @@ static void pwm_dumpregs(struct stm32_pwmtimer_s *priv, FAR const char *msg)
static int pwm_ccr_update(FAR struct pwm_lowerhalf_s *dev, uint8_t index,
uint32_t ccr)
{
FAR struct stm32_pwmtimer_s *priv = (FAR struct stm32_pwmtimer_s *)dev;
uint32_t offset = 0;
@ -2079,8 +2077,8 @@ static int pwm_frequency_update(FAR struct pwm_lowerhalf_s *dev,
uint32_t timclk = 0;
uint32_t prescaler = 0;
/* Calculate optimal values for the timer prescaler and for the timer reload
* register. If 'frequency' is the desired frequency, then
/* Calculate optimal values for the timer prescaler and for the timer
* reload register. If 'frequency' is the desired frequency, then
*
* reload = timclk / frequency
* timclk = pclk / presc
@ -2138,7 +2136,8 @@ static int pwm_frequency_update(FAR struct pwm_lowerhalf_s *dev,
reload--;
}
pwminfo("TIM%u PCLK: %u frequency: %u TIMCLK: %u prescaler: %u reload: %u\n",
pwminfo("TIM%u PCLK: %u frequency: %u TIMCLK: %u "
"prescaler: %u reload: %u\n",
priv->timid, priv->pclk, frequency, timclk, prescaler, reload);
/* Set the reload and prescaler values */
@ -2534,13 +2533,13 @@ static int pwm_output_configure(FAR struct stm32_pwmtimer_s *priv,
/* Configure output polarity (all PWM timers) */
if (priv->channels[channel-1].out1.pol == STM32_POL_NEG)
if (priv->channels[channel - 1].out1.pol == STM32_POL_NEG)
{
ccer |= (GTIM_CCER_CC1P << ((channel-1)*4));
ccer |= (GTIM_CCER_CC1P << ((channel - 1) * 4));
}
else
{
ccer &= ~(GTIM_CCER_CC1P << ((channel-1)*4));
ccer &= ~(GTIM_CCER_CC1P << ((channel - 1) * 4));
}
#ifdef HAVE_ADVTIM
@ -2549,36 +2548,36 @@ static int pwm_output_configure(FAR struct stm32_pwmtimer_s *priv,
{
/* Configure output IDLE State */
if (priv->channels[channel-1].out1.idle == STM32_IDLE_ACTIVE)
if (priv->channels[channel - 1].out1.idle == STM32_IDLE_ACTIVE)
{
cr2 |= (ATIM_CR2_OIS1 << ((channel-1)*2));
cr2 |= (ATIM_CR2_OIS1 << ((channel - 1) * 2));
}
else
{
cr2 &= ~(ATIM_CR2_OIS1 << ((channel-1)*2));
cr2 &= ~(ATIM_CR2_OIS1 << ((channel - 1) * 2));
}
#ifdef HAVE_PWM_COMPLEMENTARY
/* Configure complementary output IDLE state */
if (priv->channels[channel-1].out2.idle == STM32_IDLE_ACTIVE)
if (priv->channels[channel - 1].out2.idle == STM32_IDLE_ACTIVE)
{
cr2 |= (ATIM_CR2_OIS1N << ((channel-1)*2));
cr2 |= (ATIM_CR2_OIS1N << ((channel - 1) * 2));
}
else
{
cr2 &= ~(ATIM_CR2_OIS1N << ((channel-1)*2));
cr2 &= ~(ATIM_CR2_OIS1N << ((channel - 1) * 2));
}
/* Configure complementary output polarity */
if (priv->channels[channel-1].out2.pol == STM32_POL_NEG)
if (priv->channels[channel - 1].out2.pol == STM32_POL_NEG)
{
ccer |= (ATIM_CCER_CC1NP << ((channel-1)*4));
ccer |= (ATIM_CCER_CC1NP << ((channel - 1) * 4));
}
else
{
ccer &= ~(ATIM_CCER_CC1NP << ((channel-1)*4));
ccer &= ~(ATIM_CCER_CC1NP << ((channel - 1) * 4));
}
#endif /* HAVE_PWM_COMPLEMENTARY */
@ -2604,7 +2603,7 @@ static int pwm_output_configure(FAR struct stm32_pwmtimer_s *priv,
* which causes an ugly condition above
*/
ccer &= ~(GTIM_CCER_CC1NP << ((channel-1)*4));
ccer &= ~(GTIM_CCER_CC1NP << ((channel - 1) * 4));
}
#endif /* HAVE_GTIM_CCXNP */
@ -2729,7 +2728,8 @@ errout:
*
****************************************************************************/
static int pwm_sync_configure(FAR struct stm32_pwmtimer_s *priv, uint8_t trgo)
static int pwm_sync_configure(FAR struct stm32_pwmtimer_s *priv,
uint8_t trgo)
{
uint32_t cr2 = 0;
@ -2830,7 +2830,7 @@ static uint16_t pwm_outputs_from_channels(FAR struct stm32_pwmtimer_s *priv)
if (priv->channels[i].out1.in_use == 1)
{
outputs |= (STM32_PWM_OUT1 << ((channel-1)*2));
outputs |= (STM32_PWM_OUT1 << ((channel - 1) * 2));
}
#ifdef HAVE_PWM_COMPLEMENTARY
@ -2838,7 +2838,7 @@ static uint16_t pwm_outputs_from_channels(FAR struct stm32_pwmtimer_s *priv)
if (priv->channels[i].out2.in_use == 1)
{
outputs |= (STM32_PWM_OUT1N << ((channel-1)*2));
outputs |= (STM32_PWM_OUT1N << ((channel - 1) * 2));
}
#endif
}
@ -2907,7 +2907,6 @@ static int pwm_break_dt_configure(FAR struct stm32_pwmtimer_s *priv)
/* Configure BRK2 filter */
bdtr |= (priv->brk.flt2 << ATIM_BDTR_BK2F_SHIFT);
}
#endif /* HAVE_IP_TIMERS_V2 */
#endif /* HAVE_BREAK */

View File

@ -55,14 +55,22 @@
#include "chip.h"
#ifdef CONFIG_STM32H7_PWM
# include <arch/board/board.h>
# include "hardware/stm32_tim.h"
#endif
/************************************************************************************
* Pre-processor Definitions
************************************************************************************/
/* Configuration ********************************************************************/
/* Timer devices may be used for different purposes. One special purpose is
* to generate modulated outputs for such things as motor control. If CONFIG_STM32H7_TIMn
* is defined then the CONFIG_STM32H7_TIMn_PWM must also be defined to indicate that
* timer "n" is intended to be used for pulsed output signal generation.
* to generate modulated outputs for such things as motor control.
* If CONFIG_STM32H7_TIMn is defined then the CONFIG_STM32H7_TIMn_PWM must also be
* defined to indicate that timer "n" is intended to be used for pulsed output
* signal generation.
*/
#ifndef CONFIG_STM32H7_TIM1
@ -111,9 +119,6 @@
#ifdef CONFIG_STM32H7_PWM
#include <arch/board/board.h>
#include "hardware/stm32_tim.h"
/* PWM driver channels configuration */
#ifdef CONFIG_STM32H7_PWM_MULTICHAN
@ -915,13 +920,18 @@ enum stm32_pwm_output_e
STM32_PWM_OUT3 = (1 << 4),
STM32_PWM_OUT3N = (1 << 5),
STM32_PWM_OUT4 = (1 << 6),
/* 1 << 7 reserved - no complementary output for CH4 */
#ifdef HAVE_IP_TIMERS_V2
/* Only available inside micro */
STM32_PWM_OUT5 = (1 << 8),
/* 1 << 9 reserved - no complementary output for CH5 */
STM32_PWM_OUT6 = (1 << 10),
/* 1 << 11 reserved - no complementary output for CH6 */
#endif
};
@ -974,7 +984,8 @@ struct stm32_pwm_ops_s
/* Enable outputs */
int (*outputs_enable)(FAR struct pwm_lowerhalf_s *dev, uint16_t outputs, bool state);
int (*outputs_enable)(FAR struct pwm_lowerhalf_s *dev, uint16_t outputs,
bool state);
/* Software update */
@ -1027,7 +1038,7 @@ extern "C"
#endif
/************************************************************************************
* Public Functions
* Public Function Prototypes
************************************************************************************/
/************************************************************************************