sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

procfs: Most stat() implementations were not initializating the st_atime, st_ctime, and st_mtime fields.

Browse Source
This commit is contained in:
Gregory Nutt 2017-02-15 09:59:09 -06:00
parent bae367c7c4
commit c67943ed1d
5 changed files with 17 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/procfs/fs_procfscpuload.c
View File

@ -1,7 +1,7 @@
/**************************************************************************** /****************************************************************************
* fs/procfs/fs_procfscpuload.c * fs/procfs/fs_procfscpuload.c
* *
* Copyright (C) 2014 Gregory Nutt. All rights reserved. * Copyright (C) 2014, 2017 Gregory Nutt. All rights reserved.
* Author: Gregory Nutt <gnutt@nuttx.org> * Author: Gregory Nutt <gnutt@nuttx.org>
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -333,10 +333,8 @@ static int cpuload_stat(const char *relpath, struct stat *buf)
/* "cpuload" is the name for a read-only file */ /* "cpuload" is the name for a read-only file */
buf->st_mode = S_IFREG | S_IROTH | S_IRGRP | S_IRUSR; memset(buf, 0, sizeof(struct stat));
buf->st_size = 0; buf->st_mode = S_IFREG | S_IROTH | S_IRGRP | S_IRUSR;
buf->st_blksize = 0;
buf->st_blocks = 0;
return OK; return OK;
} }

8
fs/procfs/fs_procfskmm.c
View File

@ -1,7 +1,7 @@
/**************************************************************************** /****************************************************************************
* fs/procfs/fs_procfskmm.c * fs/procfs/fs_procfskmm.c
* *
* Copyright (C) 2016 Gregory Nutt. All rights reserved. * Copyright (C) 2016-2017 Gregory Nutt. All rights reserved.
* Author: Gregory Nutt <gnutt@nuttx.org> * Author: Gregory Nutt <gnutt@nuttx.org>
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -312,10 +312,8 @@ static int kmm_stat(FAR const char *relpath, FAR struct stat *buf)
/* "kmm" is the name for a read-only file */ /* "kmm" is the name for a read-only file */
buf->st_mode = S_IFREG | S_IROTH | S_IRGRP | S_IRUSR; memset(buf, 0, sizeof(struct stat));
buf->st_size = 0; buf->st_mode = S_IFREG | S_IROTH | S_IRGRP | S_IRUSR;
buf->st_blksize = 0;
buf->st_blocks = 0;
return OK; return OK;
} }

8
fs/procfs/fs_procfsproc.c
View File

@ -1,7 +1,7 @@
/**************************************************************************** /****************************************************************************
* fs/procfs/fs_procfsproc.c * fs/procfs/fs_procfsproc.c
* *
* Copyright (C) 2013-2016 Gregory Nutt. All rights reserved. * Copyright (C) 2013-2017 Gregory Nutt. All rights reserved.
* Author: Gregory Nutt <gnutt@nuttx.org> * Author: Gregory Nutt <gnutt@nuttx.org>
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -1552,6 +1552,7 @@ static int proc_stat(const char *relpath, struct stat *buf)
/* Was the <pid> the final element of the path? */ /* Was the <pid> the final element of the path? */
memset(buf, 0, sizeof(struct stat));
if (*ptr == '\0' || strcmp(ptr, "/") == 0) if (*ptr == '\0' || strcmp(ptr, "/") == 0)
{ {
/* Yes ... It's a read-only directory */ /* Yes ... It's a read-only directory */
@ -1601,11 +1602,6 @@ static int proc_stat(const char *relpath, struct stat *buf)
} }
} }
/* File/directory size, access block size */
buf->st_size = 0;
buf->st_blksize = 0;
buf->st_blocks = 0;
return OK; return OK;
} }

8
fs/procfs/fs_procfsuptime.c
View File

@ -1,7 +1,7 @@
/**************************************************************************** /****************************************************************************
* fs/procfs/fs_procfsuptime.c * fs/procfs/fs_procfsuptime.c
* *
* Copyright (C) 2013 Gregory Nutt. All rights reserved. * Copyright (C) 2013, 2017 Gregory Nutt. All rights reserved.
* Author: Gregory Nutt <gnutt@nuttx.org> * Author: Gregory Nutt <gnutt@nuttx.org>
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -346,10 +346,8 @@ static int uptime_stat(FAR const char *relpath, FAR struct stat *buf)
/* "uptime" is the name for a read-only file */ /* "uptime" is the name for a read-only file */
buf->st_mode = S_IFREG | S_IROTH | S_IRGRP | S_IRUSR; memset(buf, 0, sizeof(struct stat));
buf->st_size = 0; buf->st_mode = S_IFREG | S_IROTH | S_IRGRP | S_IRUSR;
buf->st_blksize = 0;
buf->st_blocks = 0;
return OK; return OK;
} }

13
fs/procfs/fs_skeleton.c
View File

@ -1,6 +1,7 @@
/**************************************************************************** /****************************************************************************
* fs/procfs/fs_skeleton.c * fs/procfs/fs_skeleton.c
* *
* Copyright (C) 2017 Gregory Nutt. All rights reserved.
* Copyright (C) 2015 Ken Pettit. All rights reserved. * Copyright (C) 2015 Ken Pettit. All rights reserved.
* Author: Ken Pettit <pettitkd@gmail.com> * Author: Ken Pettit <pettitkd@gmail.com>
* *
@ -438,7 +439,7 @@ static int skel_rewinddir(FAR struct fs_dirent_s *dir)
* *
****************************************************************************/ ****************************************************************************/
static int skel_stat(FAR const char *relpath, FAR truct stat *buf) static int skel_stat(FAR const char *relpath, FAR struct stat *buf)
{ {
int ret = -ENOENT; int ret = -ENOENT;
@ -446,15 +447,13 @@ static int skel_stat(FAR const char *relpath, FAR truct stat *buf)
* or a directory and set it's permissions. * or a directory and set it's permissions.
*/ */
memset(buf, 0, sizeof(struct stat));
buf->st_mode = S_IFDIR | S_IROTH | S_IRGRP | S_IRUSR; buf->st_mode = S_IFDIR | S_IROTH | S_IRGRP | S_IRUSR;
/* Other 'struct buf' settings may be appropriate (optional) */
ret = OK; ret = OK;
/* File/directory size, access block size */
buf->st_size = 0;
buf->st_blksize = 0;
buf->st_blocks = 0;
return ret; return ret;
} }