sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drivers: wireless: Fix _read_data() in gs2200m.c

Browse Source 
Summary:
- During reviewing the GS2200M document, I noticed that
   _read_data() implementation is incorrect.
- Actually, we do not use "SPI Byte Stuffing for SPI-NO-DMA"
  but use "SPI Command Response (SPI-DMA)", so the sequence
  should use SPI_RECVBLOCK().

Impact:
- gs2200m.c only

Testing:
- Tested with stm32f4discovery:wifi and spresense:wifi_smp

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
This commit is contained in:
Masayuki Ishikawa 2021-01-26 08:23:58 +09:00 committed by Xiang Xiao
parent b11b27d177
commit c6ed7dd760
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/wireless/gs2200m.c
View File

@ -828,19 +828,17 @@ static void _write_data(FAR struct gs2200m_dev_s *dev,
/**************************************************************************** /****************************************************************************
* Name: _read_data * Name: _read_data
* NOTE: See 3.2.2.1 SPI Byte Stuffing for the idle character * NOTE: See 3.2.2.2 SPI Command Response (SPI-DMA)
****************************************************************************/ ****************************************************************************/
static void _read_data(FAR struct gs2200m_dev_s *dev, static void _read_data(FAR struct gs2200m_dev_s *dev,
FAR uint8_t *buff, FAR uint8_t *buff,
FAR uint16_t len) FAR uint16_t len)
{ {
uint8_t req = 0xf5; /* idle character */
memset(buff, 0, len); memset(buff, 0, len);
SPI_SELECT(dev->spi, SPIDEV_WIRELESS(0), true); SPI_SELECT(dev->spi, SPIDEV_WIRELESS(0), true);
SPI_EXCHANGE(dev->spi, &req, buff, len); SPI_RECVBLOCK(dev->spi, buff, len);
SPI_SELECT(dev->spi, SPIDEV_WIRELESS(0), false); SPI_SELECT(dev->spi, SPIDEV_WIRELESS(0), false);
} }