sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tools/nxstyle.c: Add capability to detect CamelCase identifiers.

Browse Source
This commit is contained in:
Gregory Nutt 2019-03-05 13:08:57 -06:00
parent 9308c5b22b
commit c8004c7e00
2 changed files with 47 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sched/Kconfig
View File

@ -259,8 +259,12 @@ config SPINLOCK
default n
depends on ARCH_HAVE_TESTSET
---help---
Enables suppport for spinlocks. Spinlocks are current used only for
SMP suppport.
Enables suppport for spinlocks. Spinlocks are used primarily for
synchronization in SMP configurations but are available for general
synchronization between CPUs. Use in a single CPU configuration would
most likely be fatal. Note, however, that this does not depend on
CONFIG_ARCH_HAVE_MULTICPU. This permits the use of spinlocks in
other novel architectures.
config SPINLOCK_IRQ
bool "Support Spinlocks with IRQ control"

43
tools/nxstyle.c
View File

@ -1,7 +1,7 @@
/****************************************************************************
* tools/nxstyle.c
*
* Copyright (C) 2015, 2018 Gregory Nutt. All rights reserved.
* Copyright (C) 2015, 2018-2019 Gregory Nutt. All rights reserved.
* Author: Gregory Nutt <gnutt@nuttx.org>
*
* Redistribution and use in source and binary forms, with or without
@ -187,6 +187,8 @@ int main(int argc, char **argv, char **envp)
blank_lineno = -1; /* Line number of the last blank line */
noblank_lineno = -1; /* A blank line is not needed after this line */
/* Process each line in the input stream */
while (fgets(line, LINE_SIZE, instream))
{
lineno++;
@ -512,7 +514,8 @@ int main(int argc, char **argv, char **envp)
}
else if (strncmp(&line[indent], "switch(", 7) == 0)
{
fprintf(stderr, "Missing whitespace after keyword at line %d:%d\n", lineno, n);
fprintf(stderr, "Missing whitespace after keyword at line %d:%d\n",
lineno, n);
bswitch = true;
}
@ -523,6 +526,42 @@ int main(int argc, char **argv, char **envp)
for (; line[n] != '\n' && line[n] != '\0'; n++)
{
/* Skip over indentifiers */
if (ncomment == 0 && !bstring && (line[n] == '_' || isalpha(line[n])))
{
bool have_upper = false;
bool have_lower = false;
int ident_index = n;
/* Parse over the identifier. Check if it contains mixed upper-
* and lower-case characters.
*/
do
{
have_upper |= isupper(line[n]);
have_lower |= islower(line[n]);
n++;
}
while (line[n] == '_' || isalnum(line[n]));
if (have_upper && have_lower)
{
fprintf(stderr, "Mixed case identifier found at line %d:%d\n",
lineno, ident_index);
}
/* Check if the identifier is the last thing on the line */
if (line[n] == '\n' || line[n] == '\0')
{
break;
}
}
/* Handle comments */
if (line[n] == '/' && !bstring)
{
/* Check for start of a C comment */