sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

arch/sim: calling txdone callback after devif_loopback in netdriver

Browse Source 
When devif_loopback handles a packet (like a ping targeting at this dev), it does not call the txdone callback, breaking the tx pipeline and may left some packets unhandled, delayed until next transmit on the network interface.

Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
This commit is contained in:
Zhe Weng 2022-10-17 11:45:02 +08:00 committed by Xiang Xiao
parent cb25a9dee3
commit d8f35cf1b6
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
arch/sim/src/sim/up_netdriver.c
View File

@ -72,6 +72,12 @@
#include "up_internal.h"
/****************************************************************************
* Private Function Prototypes
****************************************************************************/
static void netdriver_txdone_interrupt(void *priv);
/****************************************************************************
* Private Data
****************************************************************************/
@ -290,6 +296,17 @@ static int netdriver_txpoll(struct net_driver_s *dev)
netdev_send(devidx, dev->d_buf, dev->d_len);
NETDEV_TXDONE(dev);
}
else
{
/* Calling txdone callback after loopback. NETDEV_TXDONE macro is
* already called in devif_loopback.
*
* TODO: Maybe a unified interface with txdone callback registered
* is needed, then we can let devif_loopback call this callback.
*/
netdriver_txdone_interrupt(dev);
}
}
/* If zero is returned, the polling will continue until all connections