sergiotarxz/nuttx
sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drivers/mmcsd: fix regression causing emmcsd not working

Browse Source 
Commit 50a8ec6 broke many mmc devices.  Only if the flag
priv->caps & SDIO_CAPS_4BIT_ONLY was set, it migth work.
Without the flag, the mmc clock is never set (mmcsd_widebus()
call is terminated early stopping the clock).  This flag
is probably not very generic because most mmc hw support
1, 4 and 8 bit modes.

JEDEC specifies a bus width selection procedure, but it's
not implemented in this mmcsd_sdio.c driver.  Thus, it's
not known whether the hw supports 1, 4 anf 8 bit modes or
a combination of them.

However, with priv->caps & SDIO_CAPS_4BIT_ONLY the driver
suddenly assigns priv->buswidth = MMCSD_SCR_BUSWIDTH_4BIT
making it the only way to have the driver working.

Fix this by relaxing the above mentioned restrictions.

Signed-off-by: Eero Nurkkala <eero.nurkkala@offcode.fi>
This commit is contained in:
Eero Nurkkala 2023-08-29 15:38:39 +03:00 committed by Xiang Xiao
parent c983aee38a
commit db13d5e24c
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/mmcsd/mmcsd_sdio.c
View File

@ -2564,8 +2564,10 @@ static int mmcsd_widebus(FAR struct mmcsd_state_s *priv)
} }
} }
#endif /* #ifdef CONFIG_MMCSD_MMCSUPPORT */ #endif /* #ifdef CONFIG_MMCSD_MMCSUPPORT */
else else if (!IS_SD(priv->type) && !IS_MMC(priv->type))
{ {
/* Take this path when no MMC / SD is yet detected */
fwarn("No card inserted.\n"); fwarn("No card inserted.\n");
SDIO_WIDEBUS(priv->dev, false); SDIO_WIDEBUS(priv->dev, false);
priv->widebus = false; priv->widebus = false;
@ -2577,8 +2579,17 @@ static int mmcsd_widebus(FAR struct mmcsd_state_s *priv)
/* Configure the SDIO peripheral */ /* Configure the SDIO peripheral */
if ((priv->buswidth & MMCSD_SCR_BUSWIDTH_4BIT) != 0) if ((IS_MMC(priv->type) && ((priv->caps & SDIO_CAPS_1BIT_ONLY) == 0)) ||
((priv->buswidth & MMCSD_SCR_BUSWIDTH_4BIT) != 0))
{ {
/* JEDEC specs: A.8.3 Changing the data bus width: 'Bus testing
* procedure' shows how mmc bus width may be detected. This driver
* doesn't do it, so let the low level driver decide how to go with
* the widebus selection. It may well be 1, 4 or 8 bits.
*
* For SD cards the priv->buswidth is set.
*/
finfo("Wide bus operation selected\n"); finfo("Wide bus operation selected\n");
SDIO_WIDEBUS(priv->dev, true); SDIO_WIDEBUS(priv->dev, true);
priv->widebus = true; priv->widebus = true;
@ -2768,16 +2779,15 @@ static int mmcsd_mmcinitialize(FAR struct mmcsd_state_s *priv)
mmcsd_decode_csd(priv, csd); mmcsd_decode_csd(priv, csd);
if ((priv->caps & SDIO_CAPS_4BIT_ONLY) != 0) /* It's up to the driver to act on the widebus request. mmcsd_widebus()
{ * enables the CLOCK_MMC_TRANSFER, so call it here always.
/* Select width (4-bit) bus operation (if the card supports it) */ */
ret = mmcsd_widebus(priv); ret = mmcsd_widebus(priv);
if (ret != OK) if (ret != OK)
{ {
ferr("ERROR: Failed to set wide bus operation: %d\n", ret); ferr("ERROR: Failed to set wide bus operation: %d\n", ret);
} }
}
return OK; return OK;
} }