sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sched/signal: There is no need to use sched_[un]lock

Browse Source 
purpose:
1 sched_lock is very time-consuming, and reducing its invocations can improve performance.
2 sched_lock is prone to misuse, and narrowing its scope of use is to prevent people from referencing incorrect code and using it

test:
We can use qemu for testing.
compiling
make distclean -j20; ./tools/configure.sh -l qemu-armv8a:nsh_smp ;make -j20
running
qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic -machine virt,virtualization=on,gic-version=3 -net none -chardev stdio,id=con,mux=on -serial chardev:con -mon chardev=con,mode=readline -kernel ./nuttx

We have also tested this patch on other ARM hardware platforms.
Signed-off-by: hujun5 <hujun5@xiaomi.com>
This commit is contained in:
hujun5 2024-05-07 13:49:27 +08:00 committed by Xiang Xiao
parent a14d94c548
commit ddf1410312
4 changed files with 3 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sched/signal/sig_kill.c
View File

@ -79,7 +79,6 @@ int nxsig_kill(pid_t pid, int signo)
FAR struct tcb_s *rtcb = this_task(); FAR struct tcb_s *rtcb = this_task();
#endif #endif
siginfo_t info; siginfo_t info;
int ret;
/* We do not support sending signals to process groups */ /* We do not support sending signals to process groups */
@ -95,10 +94,6 @@ int nxsig_kill(pid_t pid, int signo)
return -EINVAL; return -EINVAL;
} }
/* Keep things stationary through the following */
sched_lock();
/* Create the siginfo structure */ /* Create the siginfo structure */
info.si_signo = signo; info.si_signo = signo;
@ -112,10 +107,7 @@ int nxsig_kill(pid_t pid, int signo)
/* Send the signal */ /* Send the signal */
ret = nxsig_dispatch(pid, &info); return nxsig_dispatch(pid, &info);
sched_unlock();
return ret;
} }
/**************************************************************************** /****************************************************************************

3
sched/signal/sig_procmask.c
View File

@ -91,8 +91,6 @@ int nxsig_procmask(int how, FAR const sigset_t *set, FAR sigset_t *oset)
irqstate_t flags; irqstate_t flags;
int ret = OK; int ret = OK;
sched_lock();
/* Return the old signal mask if requested */ /* Return the old signal mask if requested */
if (oset != NULL) if (oset != NULL)
@ -148,7 +146,6 @@ int nxsig_procmask(int how, FAR const sigset_t *set, FAR sigset_t *oset)
nxsig_unmask_pendingsignal(); nxsig_unmask_pendingsignal();
} }
sched_unlock();
return ret; return ret;
} }

7
sched/signal/sig_queue.c
View File

@ -80,7 +80,6 @@ int nxsig_queue(int pid, int signo, union sigval value)
FAR struct tcb_s *rtcb = this_task(); FAR struct tcb_s *rtcb = this_task();
#endif #endif
siginfo_t info; siginfo_t info;
int ret;
sinfo("pid=0x%08x signo=%d value=%d\n", pid, signo, value.sival_int); sinfo("pid=0x%08x signo=%d value=%d\n", pid, signo, value.sival_int);
@ -105,11 +104,7 @@ int nxsig_queue(int pid, int signo, union sigval value)
/* Send the signal */ /* Send the signal */
sched_lock(); return nxsig_dispatch(pid, &info);
ret = nxsig_dispatch(pid, &info);
sched_unlock();
return ret;
} }
/**************************************************************************** /****************************************************************************

9
sched/signal/sig_tgkill.c
View File

@ -89,10 +89,6 @@ int tgkill(pid_t pid, pid_t tid, int signo)
goto errout; goto errout;
} }
/* Keep things stationary through the following */
sched_lock();
/* Create the siginfo structure */ /* Create the siginfo structure */
info.si_signo = signo; info.si_signo = signo;
@ -110,7 +106,7 @@ int tgkill(pid_t pid, pid_t tid, int signo)
if (!stcb) if (!stcb)
{ {
ret = -ESRCH; ret = -ESRCH;
goto errout_with_lock; goto errout;
} }
/* Dispatch the signal to thread, bypassing normal task group thread /* Dispatch the signal to thread, bypassing normal task group thread
@ -118,7 +114,6 @@ int tgkill(pid_t pid, pid_t tid, int signo)
*/ */
ret = nxsig_tcbdispatch(stcb, &info); ret = nxsig_tcbdispatch(stcb, &info);
sched_unlock();
if (ret < 0) if (ret < 0)
{ {
@ -127,8 +122,6 @@ int tgkill(pid_t pid, pid_t tid, int signo)
return OK; return OK;
errout_with_lock:
sched_unlock();
errout: errout:
set_errno(-ret); set_errno(-ret);
return ERROR; return ERROR;