sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sched/sched/remove_readytorun.c: Fix CPU affinity issues in SMP

Browse Source 
the logical may choose the head of g_readytorun(the greatest priority)
task as the next while ignoring the cpu affinity of it.

Signed-off-by: chenhonglin <chenhonglin@xiaomi.com>
This commit is contained in:
chenhonglin 2021-09-28 11:28:05 +08:00 committed by Masayuki Ishikawa
parent cb38060db2
commit dfc08a0b66
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sched/sched/sched_removereadytorun.c
View File

@ -209,20 +209,16 @@ bool nxsched_remove_readytorun(FAR struct tcb_s *rtcb)
if (rtrtcb != NULL && rtrtcb->sched_priority >= nxttcb->sched_priority) if (rtrtcb != NULL && rtrtcb->sched_priority >= nxttcb->sched_priority)
{ {
FAR struct tcb_s *tmptcb; /* The TCB rtrtcb has the higher priority and it can be run on
* target CPU. Remove that task (rtrtcb) from the g_readytorun
/* The TCB at the head of the ready to run list has the higher
* priority. Remove that task from the head of the g_readytorun
* list and add to the head of the g_assignedtasks[cpu] list. * list and add to the head of the g_assignedtasks[cpu] list.
*/ */
tmptcb = (FAR struct tcb_s *) dq_rem((FAR dq_entry_t *)rtrtcb, (FAR dq_queue_t *)&g_readytorun);
dq_remfirst((FAR dq_queue_t *)&g_readytorun); dq_addfirst((FAR dq_entry_t *)rtrtcb, tasklist);
dq_addfirst((FAR dq_entry_t *)tmptcb, tasklist); rtrtcb->cpu = cpu;
nxttcb = rtrtcb;
tmptcb->cpu = cpu;
nxttcb = tmptcb;
} }
/* Will pre-emption be disabled after the switch? If the lockcount is /* Will pre-emption be disabled after the switch? If the lockcount is